Skip to content

Commit c1ae511

Browse files
committed
ENH: add title to some fins plots
1 parent 9ff9581 commit c1ae511

4 files changed

Lines changed: 23 additions & 7 deletions

File tree

rocketpy/plots/aero_surface_plots.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ def roll(self):
164164
None
165165
"""
166166
print("Roll parameters:")
167-
# TODO: lacks a title in the plots
168167
self.aero_surface.roll_parameters[0]()
169168
self.aero_surface.roll_parameters[1]()
170169

@@ -226,7 +225,6 @@ def roll(self):
226225
None
227226
"""
228227
print("Roll parameters:")
229-
# TODO: lacks a title in the plots
230228
self.aero_surface.roll_parameters[0]()
231229
self.aero_surface.roll_parameters[1]()
232230

rocketpy/rocket/aero_surface/fins/_base_fin.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ def evaluate_single_fin_lift_coefficient(self):
128128
# for the specific airfoil
129129
self.airfoil_cl = Function(
130130
self.airfoil[0],
131+
title="Airfoil lift coefficient",
131132
interpolation="linear",
132133
)
133134

rocketpy/rocket/aero_surface/fins/fin.py

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@
44

55
from rocketpy.mathutils.function import Function
66
from rocketpy.mathutils.vector_matrix import Matrix, Vector
7-
from rocketpy.rocket.aero_surface.fins.base_fin import _BaseFin
8-
9-
from ..aero_surface import AeroSurface
7+
from rocketpy.rocket.aero_surface.fins._base_fin import _BaseFin
108

119

1210
class Fin(_BaseFin):
@@ -225,7 +223,17 @@ def evaluate_roll_parameters(self):
225223
roll moment damping coefficient and the cant angle in
226224
radians
227225
"""
228-
clf_delta = 0 # Not used in this class
226+
clf_delta = (
227+
self.roll_forcing_interference_factor
228+
* (self.Yma + self.rocket_radius)
229+
* self.clalpha_single_fin
230+
/ self.reference_length
231+
) # Function of mach number
232+
clf_delta.set_inputs("Mach")
233+
clf_delta.set_outputs("Roll moment forcing coefficient derivative")
234+
clf_delta.set_title(
235+
"Roll moment forcing coefficient derivative vs. Mach number"
236+
)
229237
cld_omega = -(
230238
2
231239
* self.roll_damping_interference_factor
@@ -236,6 +244,9 @@ def evaluate_roll_parameters(self):
236244
) # Function of mach number
237245
cld_omega.set_inputs("Mach")
238246
cld_omega.set_outputs("Roll moment damping coefficient derivative")
247+
cld_omega.set_title(
248+
"Roll moment damping coefficient derivative vs. Mach number"
249+
)
239250
self.roll_parameters = [clf_delta, cld_omega, self.cant_angle_rad]
240251
return self.roll_parameters
241252

rocketpy/rocket/aero_surface/fins/fins.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import numpy as np
22

33
from rocketpy.mathutils.function import Function
4-
from rocketpy.rocket.aero_surface.fins.base_fin import _BaseFin
4+
from rocketpy.rocket.aero_surface.fins._base_fin import _BaseFin
55

66
from ..aero_surface import AeroSurface
77

@@ -209,6 +209,9 @@ def evaluate_roll_parameters(self):
209209
) # Function of mach number
210210
clf_delta.set_inputs("Mach")
211211
clf_delta.set_outputs("Roll moment forcing coefficient derivative")
212+
clf_delta.set_title(
213+
"Roll moment forcing coefficient derivative vs. Mach number"
214+
)
212215
cld_omega = -(
213216
2
214217
* self.roll_damping_interference_factor
@@ -220,6 +223,9 @@ def evaluate_roll_parameters(self):
220223
) # Function of mach number
221224
cld_omega.set_inputs("Mach")
222225
cld_omega.set_outputs("Roll moment damping coefficient derivative")
226+
cld_omega.set_title(
227+
"Roll moment damping coefficient derivative vs. Mach number"
228+
)
223229
self.roll_parameters = [clf_delta, cld_omega, self.cant_angle_rad]
224230
return self.roll_parameters
225231

0 commit comments

Comments
 (0)