MNT: ruff and pylint

Author: MateusStano

rocketpy/environment/environment.py

@@ -2059,7 +2059,7 @@ def process_ensemble(self, file, dictionary):  # pylint: disable=too-many-locals
         lat_array = data.variables[dictionary["latitude"]]
 
         # Some THREDDS datasets use projected x/y coordinates.
-        #TODO CHECK THIS I AM NOT SURE?????
+        # TODO CHECK THIS I AM NOT SURE?????
         if dictionary.get("projection") is not None:
             projection_variable = data.variables[dictionary["projection"]]
             x_units = getattr(lon_array, "units", "m")

rocketpy/environment/fetchers.py

@@ -114,8 +114,7 @@ def fetch_gfs_file_return_dataset(max_attempts=10, base_delay=2):
         If unable to load the latest weather data for GFS.
     """
     file_url = (
-        "https://thredds.ucar.edu/thredds/dodsC/grib/NCEP/GFS/"
-        "Global_0p25deg/Best"
+        "https://thredds.ucar.edu/thredds/dodsC/grib/NCEP/GFS/Global_0p25deg/Best"
     )
     attempt_count = 0
     while attempt_count < max_attempts:
@@ -149,10 +148,7 @@ def fetch_nam_file_return_dataset(max_attempts=10, base_delay=2):
     RuntimeError
         If unable to load the latest weather data for NAM.
     """
-    file_url = (
-        "https://thredds.ucar.edu/thredds/dodsC/grib/NCEP/NAM/"
-        "CONUS_12km/Best"
-    )
+    file_url = "https://thredds.ucar.edu/thredds/dodsC/grib/NCEP/NAM/CONUS_12km/Best"
     attempt_count = 0
     while attempt_count < max_attempts:
         try:
@@ -185,10 +181,7 @@ def fetch_rap_file_return_dataset(max_attempts=10, base_delay=2):
     RuntimeError
         If unable to load the latest weather data for RAP.
     """
-    file_url = (
-        "https://thredds.ucar.edu/thredds/dodsC/grib/NCEP/RAP/"
-        "CONUS_13km/Best"
-    )
+    file_url = "https://thredds.ucar.edu/thredds/dodsC/grib/NCEP/RAP/CONUS_13km/Best"
     attempt_count = 0
     while attempt_count < max_attempts:
         try:
@@ -221,10 +214,7 @@ def fetch_hrrr_file_return_dataset(max_attempts=10, base_delay=2):
     RuntimeError
         If unable to load the latest weather data for HRRR.
     """
-    file_url = (
-        "https://thredds.ucar.edu/thredds/dodsC/grib/NCEP/HRRR/"
-        "CONUS_2p5km/Best"
-    )
+    file_url = "https://thredds.ucar.edu/thredds/dodsC/grib/NCEP/HRRR/CONUS_2p5km/Best"
     attempt_count = 0
     while attempt_count < max_attempts:
         try:
@@ -233,7 +223,9 @@ def fetch_hrrr_file_return_dataset(max_attempts=10, base_delay=2):
             attempt_count += 1
             time.sleep(base_delay**attempt_count)
 
-    raise RuntimeError("Unable to load latest weather data for HRRR through " + file_url)
+    raise RuntimeError(
+        "Unable to load latest weather data for HRRR through " + file_url
+    )
 
 
 def fetch_aigfs_file_return_dataset(max_attempts=10, base_delay=2):
@@ -258,8 +250,7 @@ def fetch_aigfs_file_return_dataset(max_attempts=10, base_delay=2):
         If unable to load the latest weather data for AIGFS.
     """
     file_url = (
-        "https://thredds.ucar.edu/thredds/dodsC/grib/NCEP/AIGFS/"
-        "Global_0p25deg/Best"
+        "https://thredds.ucar.edu/thredds/dodsC/grib/NCEP/AIGFS/Global_0p25deg/Best"
     )
     attempt_count = 0
     while attempt_count < max_attempts:
@@ -269,7 +260,10 @@ def fetch_aigfs_file_return_dataset(max_attempts=10, base_delay=2):
             attempt_count += 1
             time.sleep(base_delay**attempt_count)
 
-    raise RuntimeError("Unable to load latest weather data for AIGFS through " + file_url)
+    raise RuntimeError(
+        "Unable to load latest weather data for AIGFS through " + file_url
+    )
+
 
 def fetch_hiresw_file_return_dataset(max_attempts=10, base_delay=2):
     """Fetches the latest HiResW (High-Resolution Window) dataset from the NOAA's

rocketpy/environment/tools.py

@@ -133,9 +133,7 @@ def geodesic_to_lambert_conformal(lat, lon, projection_variable, x_units="m"):
     lon_radians = math.radians(lon % 360)
 
     lat_origin = math.radians(float(projection_variable.latitude_of_projection_origin))
-    lon_origin = math.radians(
-        float(projection_variable.longitude_of_central_meridian)
-    )
+    lon_origin = math.radians(float(projection_variable.longitude_of_central_meridian))
 
     standard_parallel = projection_variable.standard_parallel
     if np.ndim(standard_parallel) == 0:
@@ -157,9 +155,7 @@ def geodesic_to_lambert_conformal(lat, lon, projection_variable, x_units="m"):
     f_const = (math.cos(phi_1) * math.tan(math.pi / 4 + phi_1 / 2) ** n) / n
 
     rho = earth_radius * f_const / (math.tan(math.pi / 4 + lat_radians / 2) ** n)
-    rho_origin = (
-        earth_radius * f_const / (math.tan(math.pi / 4 + lat_origin / 2) ** n)
-    )
+    rho_origin = earth_radius * f_const / (math.tan(math.pi / 4 + lat_origin / 2) ** n)
     theta = n * (lon_radians - lon_origin)
 
     x_meters = rho * math.sin(theta)
@@ -229,7 +225,7 @@ def mask_and_clean_dataset(*args):
     return data_array
 
 
-def find_longitude_index(longitude, lon_list):
+def find_longitude_index(longitude, lon_list): # pylint: disable=too-many-statements
     """Finds the index of the given longitude in a list of longitudes.
 
     Parameters
@@ -249,6 +245,7 @@ def find_longitude_index(longitude, lon_list):
     ValueError
         If the longitude is not within the range covered by the list.
     """
+
     def _coord_value(source, index):
         return float(source[index])
 
@@ -286,7 +283,7 @@ def _coord_value(source, index):
     if lon_index == lon_len and _coord_value(lon_list, lon_index - 1) == lon:
         lon_index -= 1
     # Check if longitude value is inside the grid
-    if lon_index == 0 or lon_index == lon_len:
+    if lon_index in (0, lon_len):
         raise ValueError(
             f"Longitude {lon} not inside region covered by file, which is "
             f"from {lon_start} to {lon_end}."
@@ -315,6 +312,7 @@ def find_latitude_index(latitude, lat_list):
     ValueError
         If the latitude is not within the range covered by the list.
     """
+
     def _coord_value(source, index):
         return float(source[index])
 
@@ -338,15 +336,15 @@ def _coord_value(source, index):
     if lat_index == lat_len and _coord_value(lat_list, lat_index - 1) == latitude:
         lat_index -= 1
     # Check if latitude value is inside the grid
-    if lat_index == 0 or lat_index == lat_len:
+    if lat_index in (0, lat_len):
         raise ValueError(
             f"Latitude {latitude} not inside region covered by file, "
             f"which is from {lat_start} to {lat_end}."
         )
     return latitude, lat_index
 
 
-def find_time_index(datetime_date, time_array):
+def find_time_index(datetime_date, time_array): # pylint: disable=too-many-statements
     """Finds the index of the given datetime in a netCDF4 time array.
 
     Parameters
@@ -382,7 +380,11 @@ def find_time_index(datetime_date, time_array):
     while low < high:
         mid = (low + high) // 2
         mid_time_num = float(time_array[mid])
-        if (mid_time_num < input_time_num) if is_ascending else (mid_time_num > input_time_num):
+        if (
+            (mid_time_num < input_time_num)
+            if is_ascending
+            else (mid_time_num > input_time_num)
+        ):
             low = mid + 1
         else:
             high = mid

tests/unit/environment/test_environment.py

@@ -6,8 +6,8 @@
 import pytz
 
 from rocketpy import Environment
-from rocketpy.environment.weather_model_mapping import WeatherModelMapping
 from rocketpy.environment.tools import geodesic_to_utm, utm_to_geodesic
+from rocketpy.environment.weather_model_mapping import WeatherModelMapping
 
 
 @pytest.mark.parametrize(