Fix pylint and getattr TypeErrors

Author: Gui-FernandesBR

rocketserializer/cli.py

@@ -217,7 +217,7 @@ def ork2json(filepath, output=None, ork_jar=None, encoding="utf-8", verbose=Fals
 @click.option("--ork_jar", type=str, default=None, required=False)
 @click.option("--encoding", type=str, default="utf-8", required=False)
 @click.option("--verbose", is_flag=True, default=False, help="Enable verbose logging")
-def ork2notebook(filepath, output, ork_jar=None, encoding="utf-8", verbose=False):
+def ork2notebook(filepath, output, ork_jar=None, encoding="utf-8", verbose=False):  # pylint: disable=unused-argument
     """Generates a .ipynb file from the .ork file.
 
     Notes

rocketserializer/components/fins.py

@@ -70,10 +70,14 @@ def get_element_by_name(name):
         logger.info("Span retrieved: %f", span)
 
         sweep_length = (
-            float(getattr(fin.find("sweeplength"), "text", "0")) if fin.find("sweeplength") else None
+            float(getattr(fin.find("sweeplength"), "text", "0"))
+            if fin.find("sweeplength")
+            else None
         )
         sweep_angle = (
-            float(getattr(fin.find("sweepangle"), "text", "0")) if fin.find("sweepangle") else None
+            float(getattr(fin.find("sweepangle"), "text", "0"))
+            if fin.find("sweepangle")
+            else None
         )
         logger.info(
             "Sweep length and angle retrieved: %s, %s", sweep_length, sweep_angle

rocketserializer/components/id.py

@@ -24,20 +24,31 @@ def search_id_info(bs, filepath):
         "filepath".
     """
     settings = {}
-    settings["rocket_name"] = bs.find(getattr("rocket").find("name"), "text", "")
-    logger.info("Collected the rocket name: '%s'", settings["rocket_name"])
-
-    try:
-        settings["comment"] = bs.find(getattr("rocket").find("comment"), "text", "").replace("\n", "")
-        logger.info("Collected the comment saved in the file: %s", settings["comment"])
-    except AttributeError:
-        logger.warning("No auxiliary comment was found in the file.")
+    rocket_tag = bs.find("rocket")
+    if rocket_tag:
+        settings["rocket_name"] = getattr(rocket_tag.find("name"), "text", "")
+        logger.info("Collected the rocket name: '%s'", settings["rocket_name"])
+
+        comment_tag = rocket_tag.find("comment")
+        if comment_tag and comment_tag.text:
+            settings["comment"] = comment_tag.text.replace("\n", "")
+            logger.info(
+                "Collected the comment saved in the file: %s", settings["comment"]
+            )
+        else:
+            logger.warning("No auxiliary comment was found in the file.")
+            settings["comment"] = None
+
+        designer_tag = rocket_tag.find("designer")
+        if designer_tag and designer_tag.text:
+            settings["designer"] = designer_tag.text
+            logger.info("Collected the designer name: %s", settings["designer"])
+        else:
+            logger.warning("No designer name was found in the file.")
+            settings["designer"] = None
+    else:
+        settings["rocket_name"] = ""
         settings["comment"] = None
-    try:
-        settings["designer"] = bs.find(getattr("rocket").find("designer"), "text", "")
-        logger.info("Collected the designer name: %s", settings["designer"])
-    except AttributeError:
-        logger.warning("No designer name was found in the file.")
         settings["designer"] = None
     # settings["ork_version"] = bs.attrs["creator"]
     settings["filepath"] = Path(filepath).as_posix()

rocketserializer/components/motor.py

@@ -39,8 +39,14 @@ def search_motor(bs, datapoints, data_labels):
     settings = {}
 
     # retrieve motor geometry
-    motor_length = float(bs.find(getattr("motormount").find("length"), "text", ""))
-    motor_radius = float(bs.find(getattr("motormount").find("diameter"), "text", "")) / 2
+    motormount = bs.find("motormount")
+    if motormount is not None:
+        motor_length = float(getattr(motormount.find("length"), "text", "") or "0")
+        diam = getattr(motormount.find("diameter"), "text", "") or "0"
+        motor_radius = float(diam) / 2
+    else:
+        motor_length = 0.0
+        motor_radius = 0.0
     logger.info("Collected motor geometry: motor length and motor radius.")
 
     # get motor mass properties
@@ -183,7 +189,9 @@ def __get_motor_mass(datapoints, data_labels):
         prop_mass_vector = list(prop_mass_vector)
         logger.info("The motor dry mass is %.3f kg.", motor_dry_mass)
     else:
-        raise ValueError("Neither 'Propellant mass' nor 'Motor mass' found in data_labels.")
+        raise ValueError(
+            "Neither 'Propellant mass' nor 'Motor mass' found in data_labels."
+        )
 
     normalize = np.array(prop_mass_vector)
     normalize = normalize - normalize[np.argmin(normalize)]

rocketserializer/components/nose_cone.py

@@ -31,7 +31,8 @@ def search_nosecone(bs, elements=None, rocket_radius=None, just_radius=False):
     if not nosecone:
         nosecones = list(
             filter(
-                lambda x: getattr(x.find("name"), "text", "") == "Nosecone", bs.find_all("transition")
+                lambda x: getattr(x.find("name"), "text", "") == "Nosecone",
+                bs.find_all("transition"),
             )
         )
         if len(nosecones) == 0:

rocketserializer/components/parachute.py

@@ -33,7 +33,11 @@ def search_parachutes(bs):
         name = getattr(chute.find("name"), "text", "")
 
         # parachute settings
-        cd = "auto" if "auto" in getattr(chute.find("cd"), "text", "") else float(getattr(chute.find("cd"), "text", "0"))
+        cd = (
+            "auto"
+            if "auto" in getattr(chute.find("cd"), "text", "")
+            else float(getattr(chute.find("cd"), "text", "0"))
+        )
         cd = search_cd_chute_if_auto(chute) if cd == "auto" else cd
         area = np.pi * float(getattr(chute.find("diameter"), "text", "0")) ** 2 / 4
         cds = cd * area
@@ -70,9 +74,11 @@ def search_parachutes(bs):
 
 
 def search_cd_chute_if_auto(bs):
-    # if the parachute cd is set to "auto", OpenRocket defaults to 0.75 (flat) or 1.5 (dome).
-    # Since we cannot easily deduce the type, 0.75 is the most common standard parachute CD in OR.
+    # if the parachute cd is set to "auto", OpenRocket defaults to 0.75 (flat)
+    # or 1.5 (dome). Since we cannot easily deduce the type, 0.75 is the
+    # most common standard parachute CD in OR.
     logger.warning(
-        "cd auto: the cd is set to 0.75 for parachute %s", getattr(bs.find("name"), "text", "Unknown")
+        "cd auto: the cd is set to 0.75 for parachute %s",
+        getattr(bs.find("name"), "text", "Unknown"),
     )
     return 0.75

rocketserializer/components/rocket.py

@@ -55,8 +55,12 @@ def get_rocket_radius(bs):
     noses = bs.find_all("nosecone")
     transitions = bs.find_all("transition")
 
-    tubes_radius = [getattr(i.find("radius"), "text", "") for i in tubes if i.find("radius")]
-    noses_radius = [getattr(i.find("aftradius"), "text", "") for i in noses if i.find("aftradius")]
+    tubes_radius = [
+        getattr(i.find("radius"), "text", "") for i in tubes if i.find("radius")
+    ]
+    noses_radius = [
+        getattr(i.find("aftradius"), "text", "") for i in noses if i.find("aftradius")
+    ]
 
     # Also collect radii from transitions (foreradius and aftradius)
     transition_radius = []

rocketserializer/ork_extractor.py

@@ -48,7 +48,7 @@ def ork_extractor(bs, filepath, output_folder, ork):
     def _safe_search(func, default_ret, *args, **kwargs):
         try:
             return func(*args, **kwargs)
-        except Exception as e:
+        except Exception as e:  # pylint: disable=broad-exception-caught
             logger.error("Error extracting %s: %s", func.__name__, e, exc_info=True)
             return default_ret
 
@@ -71,7 +71,10 @@ def _safe_search(func, default_ret, *args, **kwargs):
     rocket_data = _safe_search(
         search_rocket,
         ({"center_of_mass_without_propellant": 0, "mass": 0, "radius": 0}, 0),
-        bs, datapoints, data_labels, burnout_position
+        bs,
+        datapoints,
+        data_labels,
+        burnout_position,
     )
     rocket, motor_position = rocket_data
     motors["position"] = motor_position
@@ -88,7 +91,11 @@ def _safe_search(func, default_ret, *args, **kwargs):
     elements = _safe_search(
         process_elements_position,
         {},
-        ork.getRocket(), {}, center_of_dry_mass, rocket_mass, top_position=0
+        ork.getRocket(),
+        {},
+        center_of_dry_mass,
+        rocket_mass,
+        top_position=0,
     )
     logger.info("The elements are:\n%s", _dict_to_string(elements, indent=23))
 
@@ -101,7 +108,11 @@ def _safe_search(func, default_ret, *args, **kwargs):
     stored_results = _safe_search(
         search_stored_results,
         {},
-        bs, datapoints, data_labels, time_vector, burnout_position
+        bs,
+        datapoints,
+        data_labels,
+        time_vector,
+        burnout_position,
     )
 
     # save everything to a dictionary