allow options to be overriden

Author: david-driscoll

src/Testing.SourceGenerators/GeneratorTestContextBuilder.cs

@@ -643,7 +643,7 @@ public GeneratorTestContextBuilder AddMarkup(string name, CodeMarkup source)
     {
         return this with
         {
-            _markedLocations = _markedLocations.Add(name, new(source.Location, source.Trigger)),
+            _markedLocations = _markedLocations.SetItem(name, new(source.Location, source.Trigger)),
             _sources = _sources.Add(new(SourceText.From(source.Code, Encoding.UTF8)) { Name = name, }),
         };
     }
@@ -726,14 +726,14 @@ public GeneratorTestContextBuilder AddAdditionalTexts(params IEnumerable<Additio
     public GeneratorTestContextBuilder AddOption(string path, string key, string value)
     {
         var rootOptions = _options;
-        if (rootOptions.TryGetValue(path, out var fileOptions))
+        if (_options.TryGetValue(path, out var fileOptions))
         {
-            fileOptions = fileOptions.Add(key, value);
+            fileOptions = fileOptions.SetItem(key, value);
             rootOptions = rootOptions.SetItem(path, fileOptions);
         }
         else
         {
-            rootOptions = rootOptions.SetItem(path, ImmutableDictionary<string, string>.Empty.Add(key, value));
+            rootOptions = rootOptions.SetItem(path, ImmutableDictionary<string, string>.Empty.SetItem(key, value));
         }
 
         return this with { _options = rootOptions, };
@@ -745,7 +745,7 @@ public GeneratorTestContextBuilder AddOption(string path, string key, string val
     /// <param name="key"></param>
     /// <param name="value"></param>
     /// <returns></returns>
-    public GeneratorTestContextBuilder AddGlobalOption(string key, string value) => this with { _globalOptions = _globalOptions.Add(key, value), };
+    public GeneratorTestContextBuilder AddGlobalOption(string key, string value) => this with { _globalOptions = _globalOptions.SetItem(key, value), };
 
     /// <summary>
     ///     Create the <see cref="GeneratorTestContext" /> from the builder

src/Testing.SourceGenerators/OptionsProvider.cs

@@ -1,4 +1,4 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.Diagnostics;
 
@@ -17,7 +17,7 @@ public override AnalyzerConfigOptions GetOptions(SyntaxTree tree)
         if (!options.TryGetValue(tree.FilePath, out var value)) return GlobalOptions;
         foreach (var v in globalOptions.Where(v => !value.ContainsKey(v.Key)))
         {
-            value = value.Add(v.Key, v.Value);
+            value = value.SetItem(v.Key, v.Value);
         }
 
         return new OptionsObject(value);
@@ -28,24 +28,16 @@ public override AnalyzerConfigOptions GetOptions(AdditionalText textFile)
         if (!options.TryGetValue(textFile.Path, out var value)) return GlobalOptions;
         foreach (var v in globalOptions.Where(v => !value.ContainsKey(v.Key)))
         {
-            value = value.Add(v.Key, v.Value);
+            value = value.SetItem(v.Key, v.Value);
         }
 
         return new OptionsObject(value);
     }
 
-    private sealed class OptionsObject : AnalyzerConfigOptions
+    private sealed class OptionsObject(ImmutableDictionary<string, string> properties) : AnalyzerConfigOptions
     {
-        private readonly ImmutableDictionary<string, string> _properties;
+        private readonly ImmutableDictionary<string, string> _properties = properties;
 
-        public OptionsObject(ImmutableDictionary<string, string> properties)
-        {
-            _properties = properties;
-        }
-
-        public override bool TryGetValue(string key, [NotNullWhen(true)] out string? value)
-        {
-            return _properties.TryGetValue(key, out value);
-        }
+        public override bool TryGetValue(string key, [NotNullWhen(true)] out string? value) => _properties.TryGetValue(key, out value);
     }
-}
+}