fix: auto fixtures on records fail to pick the correct constructor (#2063)

Author: RLittlesII

src/Testing.AutoFixtures/AutoFixtureGenerator+StaticGenerator.cs

@@ -237,7 +237,10 @@ IEnumerable<IParameterSymbol> parameterSymbols
             list.Add(Token(SyntaxKind.CommaToken));
         }
 
-        list.RemoveAt(list.Count - 1);
+        if (list.Count > 0)
+        {
+            list.RemoveAt(list.Count - 1);
+        }
         return GlobalStatement(
             LocalFunctionStatement(
                     IdentifierName(className),

src/Testing.AutoFixtures/AutoFixtureGenerator.cs

@@ -39,6 +39,7 @@ Compilation compilation
             namedTypeSymbol
                .Constructors
                .SelectMany(methodSymbol => methodSymbol.Parameters)
+               .Where(p => !SymbolEqualityComparer.Default.Equals(p.Type, namedTypeSymbol))
                .Distinct(ParameterReductionComparer.Default)
                .ToList();
 
@@ -105,7 +106,7 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
                .SyntaxProvider
                .ForAttributeWithMetadataName(
                     "Rocket.Surgery.Extensions.Testing.AutoFixtures.AutoFixtureAttribute",
-                    (node, _) => node.IsKind(SyntaxKind.ClassDeclaration),
+                    (node, _) => node.IsKind(SyntaxKind.ClassDeclaration) || node.IsKind(SyntaxKind.RecordDeclaration),
                     (syntaxContext, _) => syntaxContext
                 )
                .Combine(context.CompilationProvider);

test/Testing.AutoFixtures.Tests/AutoFixtureGeneratorTests.cs

@@ -56,6 +56,7 @@ public async Task GivenAutoFixture_WhenGenerate_ThenShouldGenerateAutoFixtureBas
     [MemberData(nameof(NestedClassFixtureData.Data), MemberType = typeof(NestedClassFixtureData))]
     [MemberData(nameof(DifferentNamedFixtureData.Data), MemberType = typeof(DifferentNamedFixtureData))]
     [MemberData(nameof(LazyConstructorFixtureData.Data), MemberType = typeof(LazyConstructorFixtureData))]
+    [MemberData(nameof(RecordConstructorFixtureData.Data), MemberType = typeof(RecordConstructorFixtureData))]
     public async Task GivenAutoFixtureAttribute_WhenGenerate_ThenGeneratesAutoFixture(
         GeneratorTestContext context
     )

test/Testing.AutoFixtures.Tests/RecordConstructorFixtureData.cs

@@ -0,0 +1,29 @@
+using Rocket.Surgery.Extensions.Testing.SourceGenerators;
+
+namespace Rocket.Surgery.Extensions.Testing.AutoFixtures.Tests;
+
+internal class RecordConstructorFixtureData : AutoFixtureSourceData
+{
+    public static TheoryData<GeneratorTestContext> Data =>
+    [
+        DefaultBuilder()
+           .AddSources(RecordSource, RecordFixture)
+           .Build(),
+    ];
+
+    private const string RecordSource = @"
+namespace Goony.Goo.Goo
+
+public record UserAccount(string UserId, string? LastLogin = null, string? ExpiringRefresh = null);
+";
+    private const string RecordFixture = @"
+using Rocket.Surgery.Extensions.Testing.AutoFixtures;
+
+namespace Goony.Goo.Goo.Tests
+
+[AutoFixture(typeof(UserAccount))]
+public record UserAccountFixture;
+";
+}
+
+public record UserAccount(string UserId, string? LastLogin = null, string? ExpiringRefresh = null);

test/Testing.AutoFixtures.Tests/snapshots/AutoFixtureGeneratorTests.GivenAutoFixtureAttribute_WhenGenerate_ThenGeneratesAutoFixture_context=te1vRjbKU4fFchjWuR8Awd8wAAvczcd0YqP4yTnoQs4=#UserAccount.AutoFixture.g.verified.cs

@@ -0,0 +1,20 @@
+//HintName: Rocket.Surgery.Extensions.Testing.AutoFixtures/Rocket.Surgery.Extensions.Testing.AutoFixtures.AutoFixtureGenerator/UserAccount.AutoFixture.g.cs
+using System;
+using System.Collections.ObjectModel;
+using Goony.Goo.Goo;
+using Rocket.Surgery.Extensions.Testing.AutoFixtures;
+
+namespace Goony.Goo.Goo.Tests
+{
+    internal sealed partial class UserAccountFixture : AutoFixtureBase<UserAccountFixture>
+    {
+        public static implicit operator UserAccount(UserAccountFixture fixture) => fixture.Build();
+        public UserAccountFixture WithUserId(System.String UserId) => With(ref _UserId, UserId);
+        public UserAccountFixture WithLastLogin(System.String LastLogin) => With(ref _LastLogin, LastLogin);
+        public UserAccountFixture WithExpiringRefresh(System.String ExpiringRefresh) => With(ref _ExpiringRefresh, ExpiringRefresh);
+        private UserAccount Build() => new UserAccount(_UserId, _LastLogin, _ExpiringRefresh);
+        private System.String _UserId = default;
+        private System.String _LastLogin = default;
+        private System.String _ExpiringRefresh = default;
+    }
+}

test/Testing.AutoFixtures.Tests/snapshots/AutoFixtureGeneratorTests.GivenAutoFixtureAttribute_WhenGenerate_ThenGeneratesAutoFixture_context=te1vRjbKU4fFchjWuR8Awd8wAAvczcd0YqP4yTnoQs4=.verified.txt

@@ -0,0 +1,23 @@
+{
+  AnalyzerDiagnostics: {
+    Rocket.Surgery.Extensions.Testing.AutoFixtures.Diagnostics.Rsaf0001: [],
+    Rocket.Surgery.Extensions.Testing.AutoFixtures.Diagnostics.Rsaf0002: [],
+    Rocket.Surgery.Extensions.Testing.AutoFixtures.Diagnostics.Rsaf0003: []
+  },
+  FinalDiagnostics: [],
+  GeneratorDiagnostics: {
+    Rocket.Surgery.Extensions.Testing.AutoFixtures.AutoFixtureGenerator: []
+  },
+  ParseOptions: {
+    DocumentationMode: Parse
+  },
+  References: [
+    Microsoft.Extensions.Logging.Abstractions.dll,
+    mscorlib.dll,
+    netstandard.dll,
+    System.Core.dll,
+    System.dll,
+    System.Private.CoreLib.dll,
+    System.Runtime.dll
+  ]
+}