fix(roblox-username): Get up-to-date username from Roblox instead of cached username from RoVer

Author: Archasion

src/components/VerifyDevForumRank.ts

@@ -78,27 +78,38 @@ export default class VerifyDevForumRank extends Component {
 
 	async getRobloxUsername(discordId: Snowflake, guildId: Snowflake): Promise<string | null> {
 		const endpoint = this.formatApiEndpoint(discordId, guildId);
-		const response = await fetch(endpoint, {
+		const idResponse = await fetch(endpoint, {
 			headers: {
 				// eslint-disable-next-line @typescript-eslint/naming-convention
 				Authorization: `Bearer ${process.env.ROVER_API_KEY}`
 			}
 		});
+		if (!idResponse.ok) {
+			Logger.error(`Tried fetching data from Rover API: ${idResponse.status} ${idResponse.statusText}`);
+			return null;
+		}
 
-		if (!response.ok) {
-			Logger.error(`Tried fetching data from Rover API: ${response.status} ${response.statusText}`);
+		const idData = await idResponse.json();
+		// Validate the response format
+		if (!idData || typeof idData !== "object" || !("robloxId" in idData) || typeof idData.robloxId !== "number") {
+			Logger.error(`Unknown response format from Rover API. Expected number: data.robloxId, received: ${JSON.stringify(idData)}`);
 			return null;
 		}
 
-		const data = await response.json();
+		const usernameResponse = await fetch(`https://users.roblox.com/v1/users/${idData.robloxId}`);
+		if (!usernameResponse.ok) {
+			Logger.error(`Tried fetching data from Roblox API: ${usernameResponse.status} ${usernameResponse.statusText}`);
+			return null;
+		}
 
+		const usernameData = await usernameResponse.json();
 		// Validate the response format
-		if (!data || typeof data !== "object" || !("cachedUsername" in data) || typeof data.cachedUsername !== "string") {
-			Logger.error(`Unknown response format from Rover API. Expected string: data.cachedUsername, received: ${JSON.stringify(data)}`);
+		if (!usernameData || typeof usernameData !== "object" || !("name" in usernameData) || typeof usernameData.name !== "string") {
+			Logger.error(`Unknown response format from Roblox API. Expected string: data.name, received: ${JSON.stringify(usernameData)}`);
 			return null;
 		}
 
-		return data.cachedUsername;
+		return usernameData.name;
 	}
 
 	formatApiEndpoint(discordId: Snowflake, guildId: Snowflake): `https://registry.rover.link/api/guilds/${string}/discord-to-roblox/${string}` {