chore(devforum-rank-verification): Avoid using cookie on failed request, the user is not a member if the initial request is unsuccessful

Archasion · Archasion · commit 8f9273a1ad7b · 2025-05-21T16:30:50.000+01:00
diff --git a/bot/src/components/verify_devforum_rank.rs b/bot/src/components/verify_devforum_rank.rs
@@ -238,6 +238,11 @@ async fn fetch_devforum_data(
         if let Ok(data) = res.json::<DevForumAPIResponse>().await {
             return Ok(data);
         }
+    } else {
+        anyhow::bail!(
+            "Failed to fetch DevForum data for roblox_username={roblox_username} without cookie, received status: {}",
+            res.status()
+        )
     }
 
     // Return early if the cookie is not set

Original file line number	Diff line number	Diff line change
`@@ -238,6 +238,11 @@ async fn fetch_devforum_data(`
`238`	`238`	`if let Ok(data) = res.json::<DevForumAPIResponse>().await {`
`239`	`239`	`return Ok(data);`
`240`	`240`	`}`
	`241`	`+ } else {`
	`242`	`+ anyhow::bail!(`
	`243`	`+ "Failed to fetch DevForum data for roblox_username={roblox_username} without cookie, received status: {}",`
	`244`	`+ res.status()`
	`245`	`+ )`
`241`	`246`	`}`
`242`	`247`
`243`	`248`	`// Return early if the cookie is not set`