Add per-box color support with presets and custom picker#16
Open
RohitRajendran wants to merge 2 commits into
Open
Add per-box color support with presets and custom picker#16RohitRajendran wants to merge 2 commits into
RohitRajendran wants to merge 2 commits into
Conversation
Boxes can now be color-coded: 5 muted presets rotate across newly drawn boxes, plus a custom color picker in the properties panel. Existing persisted plans with no color field keep rendering with the original blueprint blue, so this ships with no schema version bump.
…ents # Conflicts: # src/components/Canvas/BoxElement/BoxElement.tsx # src/utils/storage/storage.test.ts
✅ Deploy Preview for snapdraftfloorplans ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
colorfield keep rendering with the original blueprint blue — fully backward compatible, no schema version bump requiredsameElement()where the box comparison didn't checkcolor, which would have silently dropped color-only updates (never persisted, no undo entry)origin/main'sBox.height→Box.lengthrename (Rename box height to length #14), resolving the resulting conflicts inBoxElement.tsxandstorage.test.tsTest plan
npm run test— 359 unit tests pass, including new coverage incolors.test.ts,useFloorplanStore.test.ts,storage.test.ts,ColorPicker.test.tsx, andPropertiesPanel.test.tsxnpm run test:e2e— 130 e2e tests pass (chromium), including a newe2e/box-color.spec.tscovering color rotation, preset selection, custom color, reload persistence, and legacy-box defaultnpm run type-check,npm run lint,npm run buildall clean