N+1 Query detected

[ludwigschubert]

When using the automatic N+1 Query detector bullet in combination with rolify I get a warning about such a query:

N+1 Query detected
  Role => [:resource]
  Add to your finder: :include => [:resource]

This is non-critical, but annoying.

Thanks for your time and efforts in developing rolify! 👍

[EppO]

Good catch, I will run bullet on the specs to spot the N+1 queries.

[EppO]

Looks like it's located in the remove role method, when looking for orphaned roles.
Didn't find a quick workaround so far. it's not a great performance hit because it's looping only on the user roles after a role has been removed from that user, so if your user roles have a decent size, it's not that bad.

[ludwigschubert]

Thank you for your super quick response and effort so far!
I personally don't mind the performance hit so much, but I dislike bullet's warning - it causes you to become numb to it's warnings. I asked them about adding an option for whitelisting as well.

Thanks again and keep up the stellar work!

[EppO]

I just retried a bare app with bullet and rolify all together. After couple of examples, I couldn't reproduce the same log output you had:

ocalhost:3000http://localhost:3000/allo/remove
N+1 Query detected
  Role => [:users]
  Add to your finder: :include => [:users]
N+1 Query method call stack
  N+1 Query method call stack
  N+1 Query method call stack
  N+1 Query method call stack
  /Users/eppo/Dev/bulify/app/controllers/allo_controller.rb:9:in `remove'

it's related to users association on role class when removing a role to a user. You probably hit something else as your log output suggests a N+1 query related to resource association. Could you try to reproduce it and tell me on which method this was triggered ? thanks

[ludwigschubert]

I will, but unfortunately won't be able to before the weekend.

Thanks for your effort and super quick responses!

On Mar 17, 2013, at 7:57 PM, Florent Monbillard notifications@github.com wrote:

I just retried a bare app with bullet and rolify all together. After couple of examples, I couldn't reproduce the same log output you had:

ocalhost:3000http://localhost:3000/allo/remove
N+1 Query detected
Role => [:users]
Add to your finder: :include => [:users]
N+1 Query method call stack
N+1 Query method call stack
N+1 Query method call stack
N+1 Query method call stack
/Users/eppo/Dev/bulify/app/controllers/allo_controller.rb:9:in `remove'
it's related to users association on role class when removing a role to a user. You probably hit something else as your log output suggests a N+1 query related to resource association. Could you try to reproduce it and tell me on which method this was triggered ? thanks

—
Reply to this email directly or view it on GitHub.

[stonehz]

I run into the same problem...
did you manage to resolve it (or find a workaround)?
Thanks in advance.

[ludwigschubert]

Sorry, I wasn't. But please send a reproducible example to EppO. I was never again able to get the exact same error output, so your help would be appreciated!

[Bathakarai]

Please let me know how to solve this issue.

[imgarylai]

I also got this problem. Is there any solution now?

N+1 Query detected
  Role => [:users]
  Add to your finder: :include => [:users]
N+1 Query method call stack
  N+1 Query method call stack
  N+1 Query method call stack
  /Users/gary/Documents/works/elbum/app/controllers/teams_controller.rb:102:in `destroy'

[ludwigschubert]

Well, as for workarounds: bullet now has whitelisting.