FFG Star Wars Dice Roller

[Arcalane]

Latest version of the FFG Star Wars dice roller script is broken again-- it seems imgbox changed how embedding/direct linking works. Dice URLs just need fixing to another UK-friendly source, that's all.

[henrywild]

I think it might be that the code was never set up to release the version that contains the updated imgbox links - only version 6.3.0 is available which still has the imgur links. I'll set up a PR that actually releases version 6.4.3 with the updated links.

[Arcalane]

Those imgbox links in their current format do not correctly embed into roll20. All you'll see is this;

It needs to point to the specific files. Probably best to move to hosting them on github, similar to how the base die icons for the character sheet are hosted here, to avoid issues with image hosts changing their site formats or going out of business.

[henrywild]

Thanks Arcalane, I thought that the two issues were the same but looks like it's two separate issues. Out of interest how are you testing the output of the scripts? This is my first time working with R20 API scripts.

Also as far as I can tell, someone has already uploaded the pngs directly to this repo, they're just not implemented yet, so that'll need to be the next step

[Arcalane]

You can import any script you like if you have the necessary API access from roll20 subscriber status; I don't, but the GM for the game we're setting up does, so we've been trying to iron out issues like these before starting.

[vince-roll20]

Just chiming in. Someone reported on the forums that images are still broken. The latest version of the code points to imgbox, but they point to a page that displays the image instead of a direct link to the image. Roll20 probably doesn't recognize them as images because of this. Looks like the images are in the scripts Dice folder. Best to link to those vs offsite to be safe? Perhaps there are issues with the repo images given they were using imgur links previously?

[Arcalane]

Yes, I tried to bring this to attention on the PR that was intended to fix it (#2181) but apparently my comment was completely overlooked, resulting in the changes being approved and merged when the image links are still unusable.

I probably should have left a proper review with requested changes instead of just leaving a comment.

[vince-roll20]

@henrywild
Are you willing/able to submit a new PR with corrected image links?

Workaround; use a link to older code that uses the imgur images? (not sure if these images are still there. will still be an issue for UK users)
https://github.com/henrywild/roll20-api-scripts/blob/67533e74a557e57dfcedbeb8ee29d1bdb964a3d5/FFG-SWRPG-Dice-Roller/6.4.3/FFG-SWRPG-Dice-Roller.js

Quick fix; use the imgbox images, but grab their direct link url (ie dev tool each imgbox page)

Permanent fix; use the images hosted on roll20's repo.

[henrywild]

Hi all, apologies for not getting back to this sooner, got caught up in other work/life and didn't realise my code got merged in and thought it would just stay as is given your comment @Arcalane.

[henrywild]

Was just about to say that I'm happy to sort this out tonight but it looks like @kayochao's fix should do the job! Thanks for fixing this @kayochao!

[Arcalane]

Hi all, apologies for not getting back to this sooner, got caught up in other work/life and didn't realise my code got merged in and thought it would just stay as is given your comment @Arcalane.

That's entirely fair. To be clear I'm not particularly mad, certainly not at you, just a bit frustrated at how my commentary was overlooked on the PR itself.

[henrywild]

(In other news I am now actually getting GitHub email notifications, which I wasn't before for some unknown reason so hopefully this won't happen again 😅)

[vince-roll20]

It's all good. I know not everyone lurks on the forums but it's often the canary in the coal mine. I always like to try and contact the "closest" party before jumping in. This one seems well taken care of. Cheers