GameAssist v0.1.1.2 – Improved CritFumble Detection, Consistent GM Prompts, and Enhanced script.json Description#2074
Merged
Merged
Conversation
Added: [0.1.1.2] – 2025-06-10 ### CritFumble Module - **Natural 1 Detection Bugfix:** Refactored the `hasNaturalOne` function to robustly detect natural 1s on all d20 attack rolls, regardless of template complexity or non-standard inline roll formats. This eliminates `"Cannot read properties of undefined (reading 'r')"` errors and ensures that all valid attack rolls are properly checked for critical fumbles. - **GM Visibility Improvement:** The ❓ **Confirm Critical Miss** confirmation menu is now whispered to both the GM and the player, not just the player. This makes GM oversight consistent across all critical miss event prompts.
[0.1.1.2] – 2025-06-10 ### CritFumble Module - **Natural 1 Detection Bugfix:** Refactored the `hasNaturalOne` function to robustly detect natural 1s on all d20 attack rolls, regardless of template complexity or non-standard inline roll formats. This eliminates `"Cannot read properties of undefined (reading 'r')"` errors and ensures that all valid attack rolls are properly checked for critical fumbles. - **GM Visibility Improvement:** The ❓ **Confirm Critical Miss** confirmation menu is now whispered to both the GM and the player, not just the player. This makes GM oversight consistent across all critical miss event prompts.
Alicekb
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates GameAssist to v0.1.1.2 with a focus on improved error handling in the CritFumble module, UI consistency, and documentation/metadata clarity in script.json.
Key Changes
CritFumble Module
Natural 1 Detection Robustness:
Refactored the hasNaturalOne function to correctly detect natural 1s on d20 rolls regardless of roll template complexity. This eliminates the Cannot read properties of undefined (reading 'r') error when handling advanced or custom attack macros.
GM Whisper Consistency:
The ❓ Confirm Critical Miss prompt is now whispered to the GM in addition to the player, matching the behavior of the main critical miss menu and improving oversight during play.
script.json
Version bump:
Updated "version" to 0.1.1.2, "previousversions" array extended accordingly.
Description field improved:
Rewritten for clarity and readability, following Roll20 best practices. Description now:
Presents a clear one-line summary
Separates features, requirements, and API commands with newlines for in-app readability
Directly links to setup and troubleshooting documentation
Explicitly states TokenMod and rollable table requirements
States compatibility with the 2014 D&D 5E sheet
Other Files
No core logic changes outside CritFumble’s natural 1 detection and prompt output.
All bugfixes and enhancements are non-breaking and backward compatible.
Changelog updated accordingly.