fix: handle git users without names (#7)

Sometimes a user in git may specify an e-mail address but no name.

Author: ForbesLindesay

packages/objects/src/decodeObject.ts

@@ -179,15 +179,15 @@ function decodeTag(body: Uint8Array): TagObject {
   };
 }
 
-function decodePerson(string: string) {
-  const match = string.match(/^([^<]*) <([^>]*)> ([^ ]*) (.*)$/);
+function decodePerson(string: string): Person {
+  const match = string.match(/^(?:([^<]*) )?<([^>]*)> ([^ ]*) (.*)$/);
   if (!match) throw new Error('Improperly formatted person string');
   return {
-    name: match[1],
-    email: match[2],
+    name: match[1] ?? ``,
+    email: match[2] ?? ``,
     date: {
       seconds: parseInt(match[3], 10),
       offset: (parseInt(match[4], 10) / 100) * -60,
     },
-  } as Person;
+  };
 }

packages/objects/src/encodeObject.ts

@@ -86,7 +86,8 @@ export function encodeCommit(body: CommitBody) {
 function formatPerson(person: Person) {
   return (
     safe(person.name) +
-    ' <' +
+    (safe(person.name) ? ' ' : '') +
+    '<' +
     safe(person.email) +
     '> ' +
     formatDate(person.date)

packages/objects/src/index.test.ts

@@ -69,6 +69,37 @@ test(
   ),
 );
 
+test(
+  'save and load commit with empty person name',
+  testEncoding(
+    {
+      type: Type.commit,
+      body: {
+        tree: 'df2b8fc99e1c1d4dbc0a854d9f72157f1d6ea078',
+        parents: [],
+        author: {
+          name: '',
+          email: 'me@mariusgundersen.net',
+          date: {
+            seconds: 1500840368,
+            offset: -2 * 60,
+          },
+        },
+        committer: {
+          name: 'Marius Gundersen',
+          email: 'me@mariusgundersen.net',
+          date: {
+            seconds: 1500840368,
+            offset: -2 * 60,
+          },
+        },
+        message: 'test\n',
+      },
+    },
+    '92f15c00a43ca7bd64a94bcbee32a400f783351a',
+  ),
+);
+
 test(
   'save and load tag',
   testEncoding(