Skip to content

Commit 2b04f4a

Browse files
chore: Use max-old-space-size option according to Node.js doc
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
1 parent c94d441 commit 2b04f4a

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

build/dockerfiles/linux-libc-ubi8.Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ RUN NODE_ARCH=$(echo "console.log(process.arch)" | node) \
8080
&& mkdir -p /checode-compilation/.build/node/v${NODE_VERSION}/linux-${NODE_ARCH} \
8181
&& echo "caching /checode-compilation/.build/node/v${NODE_VERSION}/linux-${NODE_ARCH}/node" \
8282
&& cp /usr/bin/node /checode-compilation/.build/node/v${NODE_VERSION}/linux-${NODE_ARCH}/node \
83-
&& NODE_OPTIONS="--max_old_space_size=8500" ./node_modules/.bin/gulp vscode-reh-web-linux-${NODE_ARCH}-min \
83+
&& NODE_OPTIONS="--max-old-space-size=8500" ./node_modules/.bin/gulp vscode-reh-web-linux-${NODE_ARCH}-min \
8484
&& cp -r ../vscode-reh-web-linux-${NODE_ARCH} /checode
8585

8686
RUN chmod a+x /checode/out/server-main.js \

build/dockerfiles/linux-libc-ubi9.Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ RUN NODE_ARCH=$(echo "console.log(process.arch)" | node) \
8080
&& mkdir -p /checode-compilation/.build/node/v${NODE_VERSION}/linux-${NODE_ARCH} \
8181
&& echo "caching /checode-compilation/.build/node/v${NODE_VERSION}/linux-${NODE_ARCH}/node" \
8282
&& cp /usr/bin/node /checode-compilation/.build/node/v${NODE_VERSION}/linux-${NODE_ARCH}/node \
83-
&& NODE_OPTIONS="--max_old_space_size=8500" ./node_modules/.bin/gulp vscode-reh-web-linux-${NODE_ARCH}-min \
83+
&& NODE_OPTIONS="--max-old-space-size=8500" ./node_modules/.bin/gulp vscode-reh-web-linux-${NODE_ARCH}-min \
8484
&& cp -r ../vscode-reh-web-linux-${NODE_ARCH} /checode \
8585
# cache libbrotli from this image to provide it to a user's container
8686
&& mkdir -p /checode/ld_libs && find /usr/lib64 -name 'libbrotli*' 2>/dev/null | xargs -I {} cp -t /checode/ld_libs {}

build/dockerfiles/linux-musl.Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ RUN NODE_VERSION=$(cat /checode-compilation/remote/.npmrc | grep target | cut -d
6060
# workaround to fix build
6161
&& cp -r /checode-compilation/node_modules/tslib /checode-compilation/remote/node_modules/
6262

63-
RUN NODE_OPTIONS="--max_old_space_size=6500" ./node_modules/.bin/gulp vscode-reh-web-linux-alpine-min
63+
RUN NODE_OPTIONS="--max-old-space-size=6500" ./node_modules/.bin/gulp vscode-reh-web-linux-alpine-min
6464
RUN cp -r ../vscode-reh-web-linux-alpine /checode
6565

6666
RUN chmod a+x /checode/out/server-main.js \

0 commit comments

Comments
 (0)