test rebase rules#140
Open
RomanNikitenko wants to merge 34 commits into
Open
Conversation
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Assisted-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Generated-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Generated-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Generated-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Generated-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Generated-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Generated-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Generated-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Generated-by: Cursor AI
Move PR target repo and git identity into CLAUDE.md so skills resolve configuration from the repo itself rather than relying on runner-side placeholder substitution. Add an issue resolution routing table that maps issue title patterns to skill files. Clean up the workflow by removing SKILL_SOURCE, SKILL_PATH, and PR_TARGET_REPO which are no longer needed. Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Made-with: Cursor
Claude was exploring the repo and analyzing code before reaching the routing table at the bottom of the file. Move the Issue Resolution section to the top with strong directive language so Claude checks the routing table immediately upon receiving an issue reference. Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Made-with: Cursor
Add a new workflow that automatically runs dw-claude-runner when an "Alignment Che-Code with" issue is opened. Also limit the upstream release check to create only one alignment issue at a time by searching for any open alignment issue instead of a specific version. Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Made-with: Cursor
Simplify the release check to only look for the next minor version (current + 1) instead of scanning up to 10 versions ahead. Only open alignment issues block creation so closed issues can be re-created during testing. Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Made-with: Cursor
Events created with GITHUB_TOKEN do not trigger other workflows. Switch to PAT_TOKEN so the issue creation fires the trigger-rebase-on-issue workflow. Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Made-with: Cursor
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Made-with: Cursor
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Made-with: Cursor
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Made-with: Cursor
Preserve the Che-specific change that disables name mangling in the CI build task (makeCompileBuildTask(true) instead of false). Made-with: Cursor
- Add check-rebase-rules.yml: runs on PR open/sync, detects files modified in code/ without rebase rules, posts a comment listing them - Add add-rebase-rules.yml: triggered by /add-rebase-rules slash command, runs dw-claude-runner to create missing rules automatically - Add .github/scripts/check-unprotected-changes.sh: detection script that compares PR changes against rebase rules coverage - Update CLAUDE.md routing table with add-rebase-rules entry Made-with: Cursor
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
|
Click here to review and test in web IDE: |
&message=Dev%20cluster%20(for%20maintainers)&logo=eclipseche&color=525C86&labelColor=FDB940)
The detection script only reads rebase.sh and .rebase/ locally — it does not need the upstream-code remote. This saves ~2 minutes of fetching thousands of VS Code branch refs. Made-with: Cursor
The previous version only checked whether a file had any rebase rule. Now it also runs the actual rebase handler against upstream content and verifies the rule reproduces the current file — catching cases where a file was changed but the existing rule doesn't cover the new changes. Adds back upstream fetch (specific branch only) for rule validation. Made-with: Cursor
|
Pull Request images published ✨ Editor amd64: quay.io/rnikitenko/che-code:pr-140-amd64 |
Missing Rebase RulesFailed to add rebase rules. View run |
Owner
Author
|
/add-rebase-rules |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix?
How to test this PR?
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folder