[7.117] Replace axios with fetch + https fallback in che-api/github-service#145
[7.117] Replace axios with fetch + https fallback in che-api/github-service#145RomanNikitenko wants to merge 4 commits into
Conversation
941511c to
d152aae
Compare
|
Pull Request images published ✨ Editor amd64: quay.io/rnikitenko/che-code:pr-145-amd64 |
1 similar comment
|
Pull Request images published ✨ Editor amd64: quay.io/rnikitenko/che-code:pr-145-amd64 |
d152aae to
83f674d
Compare
|
Pull Request images published ✨ Editor amd64: quay.io/rnikitenko/che-code:pr-145-amd64 |
|
Pull Request images published ✨ Editor amd64: quay.io/rnikitenko/che-code:pr-145-amd64 |
1 similar comment
|
Pull Request images published ✨ Editor amd64: quay.io/rnikitenko/che-code:pr-145-amd64 |
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Assisted-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Assisted-by: Cursor AI
eab7f5f to
92a4054
Compare
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Assisted-by: Cursor AI
|
Pull Request images published ✨ Editor amd64: quay.io/rnikitenko/che-code:pr-145-amd64 |
1 similar comment
|
Pull Request images published ✨ Editor amd64: quay.io/rnikitenko/che-code:pr-145-amd64 |
…hub-service Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Assisted-by: Cursor AI
4eb0c05 to
86c1700
Compare
|
Pull Request images published ✨ Editor amd64: quay.io/rnikitenko/che-code:pr-145-amd64 |
1 similar comment
|
Pull Request images published ✨ Editor amd64: quay.io/rnikitenko/che-code:pr-145-amd64 |
What does this PR do?
What issues does this PR fix?
How to test this PR?
Start mitmproxy on the host:
2.1 Set your token in the command below
2.2 Run the che-code container with proxy settings and the mitmproxy CA:
podman run --rm -it -p 3100:3100 \ -e CODE_HOST=0.0.0.0 \ -e HTTPS_PROXY=http://host.containers.internal:8080 \ -e HTTP_PROXY=http://host.containers.internal:8080 \ -e NODE_EXTRA_CA_CERTS=/public-certs/mitmproxy-ca.crt \ -e GITHUB_TEST_TOKEN=token \ -v ~/.mitmproxy/mitmproxy-ca-cert.pem:/public-certs/mitmproxy-ca.crt:ro \ quay.io/rnikitenko/che-code:pr-145-arm64Open the editor in a browser (
incognito window) athttp://localhost:3100(see URL in the command output).F1=>Test GitHub Proxy (axios)=> see notification andcheck logs(which mechanism is used? the main? the fallback?) in the che-api outputche-api'sGithubService.getUser()(e.g. the Device Authentication flow after completing GitHub OAuth).Does this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folder