Manage install from vsix using mounting ConfigMap to the file system#18
Draft
RomanNikitenko wants to merge 5 commits into
Draft
Manage install from vsix using mounting ConfigMap to the file system#18RomanNikitenko wants to merge 5 commits into
RomanNikitenko wants to merge 5 commits into
Conversation
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
…d of ConfigMap Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
b992435 to
a9b84e7
Compare
5f8d1cb to
0d1b7c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the ability to disable 'Install from VSIX' command.
It uses Config Map approach. The ConfigMap should be created in the
eclipse-chenamespace, see https://eclipse.dev/che/docs/stable/administration-guide/configuring-a-user-namespace/I tested if it's possible to override the configuration in user's namespace when the ConfigMap is created in the
eclipse-chenamespace:Edit_ConfigMap.mov
What issues does this PR fix?
https://issues.redhat.com/browse/CRW-8313
How to test this PR?
Prerequisites
Install from VSIXcommand.The best way for testing - adding of the ConfigMap in the
eclipse-chenamespace. In this case the ConfigMap is replicated to every user namespace. The content is:If you prefer to add the ConfigMap directly in your namespace, the content is:
Use cases for testing:
Command Palette does not contain "Install from VSIX" command
F1=> start typingInstall fromInstall from VSIXcommand should be absent"Extensions" panel does not contain "Install from VSIX" action
F1=>Open View=>Extensions...on the view (Views and More Actions)Install from VSIXaction should be absent"Install Extension VSIX" action should be absent in the Explorer's context menu
vsixextensionInstall from VSIXaction should be absentIt's not possible to install VSIX extensions using "default extensions" functionality
see details about "default extensions" functionality Launching vscode with some default extensions installed che-incubator/che-code#424
default-extensionsConfigMap (see above) + the corresponding sections in the devfile allows to install defined in the devfile extensions. Check that it's not possible whenextensions.install-from-vsix-enabled": falseis defined in thevscode-editor-configurationsConfigMapNotification should be displayed when the workspace is started
ExtensionspanelDoes this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folder