Fix TLS 1.2 negotiation in Test-ListPath.ps1#1134
Merged
Merged
Conversation
Fix TLS 1.2 negotiation in Test-ListPath for corporate proxy environments
Collaborator
👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1131
Adds explicit TLS 1.2 support to
Test-ListPath.ps1, mirroring the existing pattern already used inTest-ModsPath.ps1.Problem
When fetching the excluded apps list from a remote URL behind a corporate proxy, the function fails with a TLS negotiation error. The root cause is that
SystemDefaultdoes not reliably negotiate TLS 1.2 through corporate proxies.Solution
Added
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12— the same fix already present inTest-ModsPath.ps1.Testing
Verified in a corporate proxy environment where the issue was reproduced and resolved with this change.