Skip to content

Release 2.12.0#1156

Merged
Romanitho merged 19 commits into
mainfrom
release/2.12.0
May 11, 2026
Merged

Release 2.12.0#1156
Romanitho merged 19 commits into
mainfrom
release/2.12.0

Conversation

@Romanitho

Copy link
Copy Markdown
Owner

Release 2.12.0

This PR is automatically created to perform the final tests and validations before the release is created.

Salamek and others added 18 commits March 14, 2026 16:47
required functions and replace hardoded -s 'winget' with -s $src
Remove deprecated notes regarding standalone usage and GitHub link.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
$Source, use array for $WingetArgs since parameters could also contain
spaces and that would break while using - split ""
Correct VC++ Redistributable download URL
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 8.1.0 to 8.1.1.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@c0f553f...5f6978f)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-version: 8.1.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/github-script](https://github.com/actions/github-script) from 8 to 9.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@v8...v9)

---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-version: '9'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
fix: Correctly pass value of WingetSourceCustom, Fixes #1043
…elop/peter-evans/create-pull-request-8.1.1

Bump peter-evans/create-pull-request from 8.1.0 to 8.1.1
…elop/actions/github-script-9

Bump actions/github-script from 8 to 9
Sync main to dev : Fix immutableCreate: true on github actions
Update auto-semver-action repository
@Romanitho Romanitho added the release New Release label May 11, 2026
Copilot AI review requested due to automatic review settings May 11, 2026 09:18
@github-actions

github-actions Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 2.89s
✅ POWERSHELL powershell 7 0 0 18.59s
✅ POWERSHELL powershell_formatter 7 0 0 12.4s
⚠️ REPOSITORY checkov yes 3 no 19.28s
⚠️ REPOSITORY devskim yes 1 8 3.07s
✅ REPOSITORY dustilock yes no no 0.01s
✅ REPOSITORY gitleaks yes no no 1.12s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 50.27s
✅ REPOSITORY kics yes no no 1.66s
✅ REPOSITORY kingfisher yes no no 4.69s
✅ REPOSITORY secretlint yes no no 1.31s
✅ REPOSITORY syft yes no no 2.03s
✅ REPOSITORY trivy yes no no 12.49s
✅ REPOSITORY trivy-sbom yes no no 0.18s
✅ REPOSITORY trufflehog yes no no 3.98s
⚠️ SPELL cspell 8 15 0 4.51s

Detailed Issues

⚠️ REPOSITORY / checkov - 3 errors

Linter output file not found

⚠️ SPELL / cspell - 15 errors

Linter output file not found

⚠️ REPOSITORY / devskim - 1 error

Linter output file not found

See detailed reports in MegaLinter artifacts
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Release 2.12.0 validation PR that primarily extends WAU’s WinGet operations to support a configurable package source (e.g., winget, msstore) across upgrade/install flows, alongside some workflow dependency bumps.

Changes:

  • Propagate a configurable WinGet source through upgrade/update/install paths (Update-App, Get-AppInfo, Confirm-Installation, Winget-Install, mods helpers).
  • Update GitHub Actions dependencies (pinned SHAs / major versions) and adjust workflow permissions.
  • Change the VC++ Redistributable download URL used by prerequisites installation.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Sources/Winget-AutoUpdate/Winget-Upgrade.ps1 Pass configured source into Update-App during upgrades.
Sources/Winget-AutoUpdate/Winget-Install.ps1 Add -Source parameter and use it for show and install logic.
Sources/Winget-AutoUpdate/mods/_Mods-Functions.ps1 Allow mods helper install/uninstall functions to target a specific source.
Sources/Winget-AutoUpdate/functions/Update-App.ps1 Add src parameter and use it when building winget args / querying app info.
Sources/Winget-AutoUpdate/functions/Install-Prerequisites.ps1 Update VC++ redist URL.
Sources/Winget-AutoUpdate/functions/Get-AppInfo.ps1 Add src parameter with fallback normalization; query winget show using it.
Sources/Winget-AutoUpdate/functions/Confirm-Installation.ps1 Add src parameter and use it for winget export.
.github/workflows/GitFlow_Nightly-builds.yml Bump auto-semver action pin.
.github/workflows/GitFlow_Create-Release-Branch-and-PR.yaml Bump auto-semver action pin.
.github/workflows/GitFlow_Check-pull-request-source-branch.yml Bump actions/github-script to v9.
.github/workflows/GA_Mega-linter.yml Bump peter-evans/create-pull-request pin.
.github/workflows/GA_Close-Inactive-Issues.yml Remove unneeded contents: write permission.
Comments suppressed due to low confidence (1)

Sources/Winget-AutoUpdate/functions/Confirm-Installation.ps1:25

  • Confirm-Installation is currently called as an “installed?” check (e.g., without passing AppVer), which relies on $AppVer being $null and the implicit pattern "$AppVer*" becoming *. This is fragile/implicit; consider handling the two modes explicitly (if AppVer is null/empty then match only PackageIdentifier, else also match version prefix) and clarify the comment-based help accordingly.
    $Packages = (Get-Content $JsonFile -Raw | ConvertFrom-Json).Sources.Packages
    $match = $Packages | Where-Object { $_.PackageIdentifier -eq $AppName -and $_.Version -like "$AppVer*" }

Comment on lines +15 to 20
Function Update-App ($app, $src = "winget") {

# Helper function to build winget command parameters
function Get-WingetParams ($Command, $ModsOverride, $ModsCustom, $ModsArguments) {
$params = @($Command, "--id", $app.Id, "-e", "--accept-package-agreements", "--accept-source-agreements", "-s", "winget")
$params = @($Command, "--id", $app.Id, "-e", "--accept-package-agreements", "--accept-source-agreements", "-s", $src)
if ($Command -eq "install") { $params += "--force" }
Comment on lines 18 to 22
Function Confirm-Installation ($AppName, $AppVer, $src) {

$JsonFile = "$env:TEMP\InstalledApps.json"
& $Winget export -s winget -o $JsonFile --include-versions | Out-Null
& $Winget export -s $src -o $JsonFile --include-versions | Out-Null

Comment on lines 45 to 51
[Parameter(Mandatory = $True, ParameterSetName = "AppIDs")] [String[]] $AppIDs,
[Parameter(Mandatory = $False)] [Switch] $Uninstall,
[Parameter(Mandatory = $False)] [String] $LogPath,
[Parameter(Mandatory = $False)] [Switch] $WAUWhiteList,
[Parameter(Mandatory = $False)] [Switch] $AllowUpgrade
[Parameter(Mandatory = $False)] [Switch] $AllowUpgrade,
[Parameter(Mandatory = $False)] [String] $Source = "winget"
)
@Romanitho

Copy link
Copy Markdown
Owner Author

@copilot apply changes based on the comments in this thread

Copilot AI commented May 11, 2026

Copy link
Copy Markdown
Contributor

@copilot apply changes based on the comments in this thread

Applied the requested review-thread fixes in commit 5beb7c6: added null/whitespace-safe source fallback to Update-App and Confirm-Installation (with optional default), and documented -Source in Winget-Install.ps1 help with an example.

@Romanitho
Romanitho merged commit 5e87897 into main May 11, 2026
2 checks passed
@Romanitho
Romanitho deleted the release/2.12.0 branch May 12, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release New Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants