feat: Implement setNamespace method#65
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94ee5d5fdb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Coverage Report for CI Build 28269805567Coverage increased (+0.05%) to 98.741%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f34e2fb06a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| { | ||
| foreach ($nodes as $node) { | ||
| if ($node instanceof Namespace_) { | ||
| if ($node->name->toString() === $this->namespace) { |
There was a problem hiding this comment.
Guard this comparison against Namespace_ nodes whose name is null (for example, files using namespace { ... } global blocks). In that case, calling toString() throws at runtime, so setNamespace() crashes instead of rewriting the file. This regression is input-dependent but affects valid PHP files that parse to anonymous namespace nodes.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Anonymous namespaces cannot be PSR-4 autoloaded, so this case is intentionally not supported.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3631d2807
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if ($node instanceof Declare_) { | ||
| $declares[] = $node; | ||
|
|
||
| unset($nodes[$key]); |
There was a problem hiding this comment.
The new namespace insertion path hoists every top-level declare out of its original position before wrapping the rest of the file in namespace ...;. This changes runtime behavior for valid files that use non-strict_types declares (for example declare(ticks=1);) after some statements, because the directive is now applied from the top of the script. To avoid semantic changes, only preserve leading declare(strict_types=1) (or otherwise reject unsupported declare layouts) instead of relocating all Declare_ nodes.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3072a5950d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| protected function updateNamespace(Namespace_ $node): ?array | ||
| { | ||
| if ($node->name->toString() !== $this->namespace) { |
There was a problem hiding this comment.
When setNamespace() is called on a file that uses a bracketed global namespace (namespace { ... }), PhpParser represents that namespace with name === null, so this dereference fatals before the requested namespace can be applied. Treating a null name as “no namespace yet” would let those valid PHP files be converted instead of crashing.
Useful? React with 👍 / 👎.
2 participants
No description provided.