-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Implement setNamespace method #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
artengin
wants to merge
4
commits into
master
Choose a base branch
from
implement-set-namespace-method
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+128
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
94ee5d5
feat: Implement setNamespace method
artengin f34e2fb
fix: keep declare() outside namespace when adding namespace to file w…
artengin 46e439d
docs: add setNamespace() to README
artengin b3631d2
Merge branch 'master' into implement-set-namespace-method
artengin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| <?php | ||
|
|
||
| namespace RonasIT\Larabuilder\Visitors; | ||
|
|
||
| use PhpParser\Node\Name; | ||
| use PhpParser\Node\Stmt\Declare_; | ||
| use PhpParser\Node\Stmt\Namespace_; | ||
| use PhpParser\NodeVisitorAbstract; | ||
|
|
||
| class SetNamespace extends NodeVisitorAbstract | ||
| { | ||
| public function __construct( | ||
| protected string $namespace, | ||
| ) { | ||
| } | ||
|
|
||
| public function afterTraverse(array $nodes): ?array | ||
| { | ||
| $declares = []; | ||
|
|
||
| foreach ($nodes as $key => $node) { | ||
| if ($node instanceof Namespace_) { | ||
| return $this->updateNamespace($node); | ||
| } | ||
|
|
||
| if ($node instanceof Declare_) { | ||
| $declares[] = $node; | ||
|
|
||
| unset($nodes[$key]); | ||
| } | ||
| } | ||
|
|
||
| return [...$declares, new Namespace_(new Name($this->namespace), array_values($nodes))]; | ||
| } | ||
|
|
||
| protected function updateNamespace(Namespace_ $node): ?array | ||
| { | ||
| if ($node->name->toString() !== $this->namespace) { | ||
| $node->name = new Name($this->namespace); | ||
| } | ||
|
|
||
| return null; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| class SomeClass | ||
| { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace App\Models; | ||
|
|
||
| class SomeClass | ||
| { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| <?php | ||
|
|
||
| namespace App\Models; | ||
|
|
||
| enum SomeEnum | ||
| { | ||
| case First; | ||
| case Second; | ||
|
|
||
| public static function toArray(): array | ||
| { | ||
| return self::cases(); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new namespace insertion path hoists every top-level
declareout of its original position before wrapping the rest of the file innamespace ...;. This changes runtime behavior for valid files that use non-strict_typesdeclares (for exampledeclare(ticks=1);) after some statements, because the directive is now applied from the top of the script. To avoid semantic changes, only preserve leadingdeclare(strict_types=1)(or otherwise reject unsupported declare layouts) instead of relocating allDeclare_nodes.Useful? React with 👍 / 👎.