PRD-2078: Stop response generation#6
Merged
Conversation
# Conflicts: # libs/mobile/shared/features/use-audio-recorder/src/hook.ts
Collaborator
Author
|
@veliseev93 could you please take a look? |
Contributor
|
@Tomass673 The basic logic works well, but could you please make a few changes:
|
ci: add validation workflow for pull requests and pushes
veliseev93
reviewed
Dec 4, 2025
| /> | ||
| {isResponseGenerating ? ( | ||
| <IconButton | ||
| iconName='stopCircle' |
Contributor
There was a problem hiding this comment.
@Tomass673 Could you please use this icon to keep the button style consistent?
stop.svg.zip
So, the button should look lie this:
| field.onChange(text); | ||
| }; | ||
|
|
||
| const onStopGenerationPress = async (): Promise<void> => { |
Contributor
There was a problem hiding this comment.
After stopping response generation, we should also mark the last message as done: true. We use this flag to determine whether a response is still being generated or not. This can be done by patching the chat like this: patch-new-chat.ts.
We also patch this field for messages when retrieving the chat in chat api ( there is similar logic in the web application ).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: https://app.clickup.com/t/24336023/PRD-2078