Skip to content

PRD-2076: Fix isResponseGenerating behavior #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tomass673 wants to merge 3 commits into from
Closed

PRD-2076: Fix isResponseGenerating behavior #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49ae5a9
fix: continue response generating isResponseGenerating behavior fix
Dec 10, 2025
96c6da5
chore: mark message generating simplified
Dec 10, 2025
7330b38
fix: determine the last assistant message in ui instead of using hist…
Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/mobile/chat/features/chat/src/lib/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export function Chat({ chatId, selectedModelId, isNewChat, resetToChatsList }: C
} = useEditMessage({ chat, modelId: selectedModelId });

const history = chat?.chat.history;
const isResponseGenerating = !history?.messages[history.currentId].done;
const isResponseGenerating = history?.lastAssistantMessage?.done !== true;

@veliseev93 veliseev93 Dec 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes related to lastAssistantMessage cause a bug when switching message history. If we return to an old chat thread, the input becomes disabled.

Untitled.mov.zip


const shouldHideContent = isLoading || isRefetching || !isMessagesListLoaded || !selectedModelId;

Expand Down
21 changes: 20 additions & 1 deletion libs/mobile/chat/features/chat/src/lib/components/messages-list/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@ import { useSetSelectedModel } from '@open-webui-react-native/mobile/shared/feat
import { View, AppFlashList } from '@open-webui-react-native/mobile/shared/ui/ui-kit';
import { ChatScreenParams } from '@open-webui-react-native/mobile/shared/utils/navigation';
import {
Chat,
chatApi,
History as ChatHistory,
Message,
patchChatQueryData,
prepareCompleteChatPayload,
} from '@open-webui-react-native/shared/data-access/api';
import { Role } from '@open-webui-react-native/shared/data-access/common';
Expand Down Expand Up @@ -131,6 +133,19 @@ export default function ChatMessagesList({
const handleContinueResponsePress = (messageId: string): void => {
if (!modelId) return;

// mark message as not completed
patchChatQueryData(chatId, {

@veliseev93 veliseev93 Dec 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is enough to fix the original bug, why do we need the rest of the changes?

chat: {
history: {
messages: {
[messageId]: {
done: false,
},
},
},
} as Chat,
});

const completePayload = prepareCompleteChatPayload({
chatId,
messages,
Expand All @@ -146,7 +161,11 @@ export default function ChatMessagesList({
const message = history?.messages[item.id];
if (!message) return null;

const isLast = item.id === history?.lastAssistantMessage?.id;
const lastAssistantMessageInUIList = [...messages]
.reverse()
.find((m) => history?.messages[m.id]?.role === Role.ASSISTANT);

const isLast = item.id === lastAssistantMessageInUIList?.id;

return item.role === Role.ASSISTANT ? (
<AiMessageActions
Expand Down
9 changes: 4 additions & 5 deletions libs/shared/data-access/api/src/lib/chats/utils/patch-completed-message.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Role } from '@open-webui-react-native/shared/data-access/common';
import { ChatResponse, Message } from '../models';
import { ChatResponse, Message, History } from '../models';

export function patchCompletedMessage(oldData: ChatResponse | undefined): ChatResponse | undefined {
if (
Expand Down Expand Up @@ -33,11 +33,10 @@ export function patchCompletedMessage(oldData: ChatResponse | undefined): ChatRe
: undefined;

const updatedHistory = updatedHistoryMessages
? {
...history,
? new History({
messages: updatedHistoryMessages,
lastAssistantMessage: history?.lastAssistantMessage ?? updatedLastMessage,
}
currentId: history.currentId,
})
: history;

return {
Expand Down
Loading