forked from pytest-dev/pytest
-
Notifications
You must be signed in to change notification settings - Fork 0
Ronny/claude experiment/opt in function definition #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RonnyPfannschmidt
wants to merge
15
commits into
main
Choose a base branch
from
ronny/claude-experiment/opt-in-function-definition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1d31273
refactor: Remove lazy loading from PyobjMixin and simplify module imp…
RonnyPfannschmidt a10bc95
WIP: Refactor PyobjMixin to remove lazy loading and unify instance ma…
RonnyPfannschmidt ac9f29d
Refactor PyobjMixin for eager object passing and fix marker collection
RonnyPfannschmidt 6a896af
Fix mypy errors from PyobjMixin refactoring
RonnyPfannschmidt 2fd2803
Fix DefinitionMock to use proper __init__ instead of dataclass
RonnyPfannschmidt b28ea37
Fix test_class_from_parent to use cooperative constructor
RonnyPfannschmidt 80e4d72
Add filterwarnings marker to TestConftestValueAccessGlobal
RonnyPfannschmidt cc8faa1
Implement lazy loading for Module.obj using cached property
RonnyPfannschmidt 8239cb3
Fix test_pytest_pycollect_makeitem to pass callobj to Function.from_p…
RonnyPfannschmidt ccd34f2
Make Function.from_parent auto-resolve callobj from parent
RonnyPfannschmidt e1ab6f2
Fix setup_method/teardown_method to receive bound methods
RonnyPfannschmidt e7a57cf
Summary: PyobjMixin refactoring progress
RonnyPfannschmidt 16c9411
Fix fixture handling for class/static methods and add Function.instan…
RonnyPfannschmidt 11c1b1b
WIP: Messy intermediate state - opt-in function definition refactoring
RonnyPfannschmidt 6d86679
one more intermediate, im done here omg
RonnyPfannschmidt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "permissions": { | ||
| "allow": [ | ||
| "Bash(grep:*)", | ||
| "Bash(uv run pytest:*)" | ||
| ], | ||
| "deny": [] | ||
| }, | ||
| "outputStyle": "default" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (code-quality): Invert any/all to simplify comparisons (
invert-any-all)