docs: enhance terminal output limit description for clarity and token…#128
Merged
Conversation
dosubot
Bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 108ffa5 in 1 minute and 4 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. docs/features/shell-integration.md:35
- Draft comment:
The enhanced description for 'Terminal Output Limit' provides more detailed behavior (keeping 20% of the beginning and 80% of the end with a truncation message), which is great for clarity. However, this new line is immediately followed by another description stating that "lines are removed from the middle to save tokens," which may cause redundancy or confusion. Please consolidate these lines to present a single, consistent explanation that reflects the actual behavior. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_q49bhAt3vcuyyy1r
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| #### Terminal Output Limit | ||
| <img src="/img/shell-integration/shell-integration.png" alt="Terminal output limit slider set to 500" width="600" /> | ||
|
|
||
| Controls the maximum number of lines captured from terminal output. When exceeded, it keeps 20% of the beginning and 80% of the end with a truncation message in between. This prevents excessive token usage while maintaining context. Default: 500 lines. |
Contributor
There was a problem hiding this comment.
Duplicate description issue: Two consecutive descriptions for the Terminal Output Limit are present. Consolidate or clarify to ensure only one clear description is shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… management
Important
Clarifies
Terminal Output Limitbehavior inshell-integration.mdby specifying line retention strategy and purpose.Terminal Output Limitdescription inshell-integration.mdto clarify behavior when limit is exceeded.This description was created by
for 108ffa5. It will automatically update as commits are pushed.