docs: Add contributing guide to sidebar navigation#175
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 9299df4 in 2 minutes and 1 seconds. Click for details.
- Reviewed
224lines of code in2files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/contributing.md:205
- Draft comment:
Consider adding a trailing newline at the end of the file to adhere to style guidelines. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% While having a trailing newline is a common style guideline, this kind of formatting issue should be handled automatically by ESLint/Prettier rather than manual code review comments. Our rules specifically state that we should let automated tools handle code style issues. Additionally, this is a very minor formatting issue that doesn't impact functionality. The comment is technically correct - many style guides do recommend trailing newlines. And this is a new file, so we could catch this early. However, our rules explicitly state that code style issues should be handled by ESLint and Prettier with pre-commit hooks, not manual review comments. Making style comments creates noise and reduces focus on more important issues. Delete this comment. Style formatting like trailing newlines should be handled automatically by ESLint/Prettier, not manual review comments.
2. sidebars.ts:132
- Draft comment:
Ensure the new 'contributing' sidebar entry is correctly positioned and links to the intended document. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
3. sidebars.ts:132
- Draft comment:
Added 'contributing' to the sidebar. Ensure that the doc ID matches the filename (defaults to 'contributing'). - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
4. docs/contributing.md:140
- Draft comment:
Typographical error: The installation command on line 140 uses 'roo-cline-.vsix'. This seems like a typo — it likely should be 'roo-code-.vsix' to match the rest of the project naming. Please verify and correct this string. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_qiBSnkMf6m7M09td
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
| Alternatively, build and install a `.vsix`: | ||
| ```sh | ||
| npm run build | ||
| code --install-extension bin/roo-cline-.vsix |
Contributor
There was a problem hiding this comment.
The VS Code extension install command (roo-cline-.vsix) might be a typo. Confirm if it should be roo-code-.vsix or another name.
Suggested change
| code --install-extension bin/roo-cline-.vsix | |
| code --install-extension bin/roo-code-.vsix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add
contributing.mdto the documentation and updatesidebars.tsto include it in the sidebar navigation.contributing.mdto provide guidelines for contributing to Roo Code.sidebars.tsto includecontributing.mdin the sidebar under the main navigation.This description was created by
for 9299df4. You can customize this summary. It will automatically update as commits are pushed.