This repository was archived by the owner on May 15, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Expand file tree
/
Copy pathapiMessages.spec.ts
More file actions
241 lines (189 loc) · 8.48 KB
/
Copy pathapiMessages.spec.ts
File metadata and controls
241 lines (189 loc) · 8.48 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
import { describe, it, expect, beforeEach, afterEach, vi } from "vitest"
import * as fs from "fs/promises"
import * as path from "path"
import { readApiMessages, saveApiMessages } from "../apiMessages"
// Mock dependencies
vi.mock("../../../utils/fs")
vi.mock("../../../utils/storage")
vi.mock("fs/promises")
vi.mock("../../../utils/safeWriteJson")
const { fileExistsAtPath } = await import("../../../utils/fs")
const { getTaskDirectoryPath } = await import("../../../utils/storage")
const { safeWriteJson } = await import("../../../utils/safeWriteJson")
describe("apiMessages", () => {
const mockTaskId = "test-task-id"
const mockGlobalStoragePath = "/mock/storage"
const mockTaskDir = "/mock/storage/tasks/test-task-id"
const mockFilePath = path.join(mockTaskDir, "api_conversation_history.json")
beforeEach(() => {
vi.clearAllMocks()
vi.mocked(getTaskDirectoryPath).mockResolvedValue(mockTaskDir)
})
afterEach(() => {
vi.resetAllMocks()
})
describe("readApiMessages - validation", () => {
it("should successfully read and return valid messages", async () => {
const validMessages = [
{ role: "user", content: "Hello" },
{ role: "assistant", content: [{ type: "text", text: "Hi there!" }] },
]
vi.mocked(fileExistsAtPath).mockResolvedValue(true)
vi.mocked(fs.readFile).mockResolvedValue(JSON.stringify(validMessages))
const result = await readApiMessages({ taskId: mockTaskId, globalStoragePath: mockGlobalStoragePath })
expect(result).toHaveLength(2)
expect(result[0]).toEqual({ role: "user", content: "Hello" })
expect(result[1]).toEqual({ role: "assistant", content: [{ type: "text", text: "Hi there!" }] })
})
it("should fix messages with undefined content", async () => {
const messagesWithUndefinedContent = [
{ role: "user", content: "Valid" },
{ role: "assistant", content: undefined },
{ role: "user", content: "Continue" },
]
vi.mocked(fileExistsAtPath).mockResolvedValue(true)
vi.mocked(fs.readFile).mockResolvedValue(JSON.stringify(messagesWithUndefinedContent))
const result = await readApiMessages({ taskId: mockTaskId, globalStoragePath: mockGlobalStoragePath })
expect(result).toHaveLength(3)
expect(result[0].content).toBe("Valid")
expect(result[1].content).toEqual([]) // Fixed from undefined to empty array
expect(result[2].content).toBe("Continue")
})
it("should fix messages with null content", async () => {
const messagesWithNullContent = [
{ role: "user", content: "Valid" },
{ role: "assistant", content: null },
{ role: "user", content: "Continue" },
]
vi.mocked(fileExistsAtPath).mockResolvedValue(true)
vi.mocked(fs.readFile).mockResolvedValue(JSON.stringify(messagesWithNullContent))
const result = await readApiMessages({ taskId: mockTaskId, globalStoragePath: mockGlobalStoragePath })
expect(result).toHaveLength(3)
expect(result[0].content).toBe("Valid")
expect(result[1].content).toEqual([]) // Fixed from null to empty array
expect(result[2].content).toBe("Continue")
})
it("should fix messages with non-array, non-string content", async () => {
const messagesWithInvalidContent = [
{ role: "user", content: "Valid" },
{ role: "assistant", content: { invalid: "object" } },
{ role: "user", content: "Continue" },
]
vi.mocked(fileExistsAtPath).mockResolvedValue(true)
vi.mocked(fs.readFile).mockResolvedValue(JSON.stringify(messagesWithInvalidContent))
const result = await readApiMessages({ taskId: mockTaskId, globalStoragePath: mockGlobalStoragePath })
expect(result).toHaveLength(3)
expect(result[0].content).toBe("Valid")
expect(result[1].content).toEqual([]) // Fixed from object to empty array
expect(result[2].content).toBe("Continue")
})
it("should filter out messages with invalid roles", async () => {
const messagesWithInvalidRoles = [
{ role: "user", content: "Valid" },
{ role: "invalid_role", content: "Bad message" },
{ role: "assistant", content: "Also valid" },
]
vi.mocked(fileExistsAtPath).mockResolvedValue(true)
vi.mocked(fs.readFile).mockResolvedValue(JSON.stringify(messagesWithInvalidRoles))
const result = await readApiMessages({ taskId: mockTaskId, globalStoragePath: mockGlobalStoragePath })
expect(result).toHaveLength(2)
expect(result[0].role).toBe("user")
expect(result[1].role).toBe("assistant")
})
it("should filter out completely malformed messages (not objects)", async () => {
const messagesWithNonObjects = [
{ role: "user", content: "Valid" },
null,
"string message",
123,
{ role: "assistant", content: "Also valid" },
]
vi.mocked(fileExistsAtPath).mockResolvedValue(true)
vi.mocked(fs.readFile).mockResolvedValue(JSON.stringify(messagesWithNonObjects))
const result = await readApiMessages({ taskId: mockTaskId, globalStoragePath: mockGlobalStoragePath })
expect(result).toHaveLength(2)
expect(result[0].role).toBe("user")
expect(result[1].role).toBe("assistant")
})
it("should filter out invalid blocks from message content arrays", async () => {
const messagesWithInvalidBlocks = [
{
role: "assistant",
content: [
{ type: "text", text: "Valid text" },
null, // Invalid block
{ invalid: "no type field" }, // Invalid block
{ type: "text", text: "Another valid text" },
],
},
]
vi.mocked(fileExistsAtPath).mockResolvedValue(true)
vi.mocked(fs.readFile).mockResolvedValue(JSON.stringify(messagesWithInvalidBlocks))
const result = await readApiMessages({ taskId: mockTaskId, globalStoragePath: mockGlobalStoragePath })
expect(result).toHaveLength(1)
expect(Array.isArray(result[0].content)).toBe(true)
expect((result[0].content as any[]).length).toBe(2)
expect((result[0].content as any[])[0]).toEqual({ type: "text", text: "Valid text" })
expect((result[0].content as any[])[1]).toEqual({ type: "text", text: "Another valid text" })
})
it("should return empty array when parsedData is not an array", async () => {
const nonArrayData = { invalid: "not an array" }
vi.mocked(fileExistsAtPath).mockResolvedValue(true)
vi.mocked(fs.readFile).mockResolvedValue(JSON.stringify(nonArrayData))
const result = await readApiMessages({ taskId: mockTaskId, globalStoragePath: mockGlobalStoragePath })
expect(result).toEqual([])
})
it("should preserve valid metadata fields (ts, isSummary, etc.)", async () => {
const messagesWithMetadata = [
{
role: "user",
content: "Test",
ts: 1234567890,
isSummary: true,
condenseId: "c-123",
truncationId: "t-456",
},
]
vi.mocked(fileExistsAtPath).mockResolvedValue(true)
vi.mocked(fs.readFile).mockResolvedValue(JSON.stringify(messagesWithMetadata))
const result = await readApiMessages({ taskId: mockTaskId, globalStoragePath: mockGlobalStoragePath })
expect(result).toHaveLength(1)
expect(result[0].ts).toBe(1234567890)
expect(result[0].isSummary).toBe(true)
expect(result[0].condenseId).toBe("c-123")
expect(result[0].truncationId).toBe("t-456")
})
it("should handle old claude_messages.json format with validation", async () => {
const oldFormatMessages = [
{ role: "user", content: "Valid" },
{ role: "assistant", content: undefined }, // Should be fixed
]
// New format doesn't exist, old format exists
vi.mocked(fileExistsAtPath)
.mockResolvedValueOnce(false) // New format
.mockResolvedValueOnce(true) // Old format
vi.mocked(fs.readFile).mockResolvedValue(JSON.stringify(oldFormatMessages))
// Mock unlink to prevent errors
;(fs as any).unlink = vi.fn().mockResolvedValue(undefined)
const result = await readApiMessages({ taskId: mockTaskId, globalStoragePath: mockGlobalStoragePath })
expect(result).toHaveLength(2)
expect(result[0].content).toBe("Valid")
expect(result[1].content).toEqual([]) // Fixed from undefined
})
it("should return empty array when no file exists", async () => {
vi.mocked(fileExistsAtPath).mockResolvedValue(false)
const result = await readApiMessages({ taskId: mockTaskId, globalStoragePath: mockGlobalStoragePath })
expect(result).toEqual([])
})
})
describe("saveApiMessages", () => {
it("should call safeWriteJson with correct parameters", async () => {
const messages = [
{ role: "user", content: "Test" },
{ role: "assistant", content: [{ type: "text", text: "Response" }] },
] as any[]
await saveApiMessages({ messages, taskId: mockTaskId, globalStoragePath: mockGlobalStoragePath })
expect(safeWriteJson).toHaveBeenCalledWith(mockFilePath, messages)
})
})
})