Update ChatView welcome tests after cloud removal

Author: mrubens

webview-ui/src/components/chat/__tests__/ChatView.spec.tsx

@@ -662,15 +662,13 @@ describe("ChatView - Version Indicator Tests", () => {
 	})
 })
 
-describe("ChatView - DismissibleUpsell Display Tests", () => {
+describe("ChatView - Welcome Content Display Tests", () => {
 	beforeEach(() => vi.clearAllMocks())
 
-	it("does not show DismissibleUpsell when user is authenticated to Cloud", () => {
+	it("does not show removed cloud upsell for returning users", () => {
 		const { queryByTestId } = renderChatView()
 
-		// Hydrate state with user authenticated to cloud
 		mockPostMessage({
-			cloudIsAuthenticated: true,
 			taskHistory: [
 				{ id: "1", ts: Date.now() - 3000 },
 				{ id: "2", ts: Date.now() - 2000 },
@@ -680,16 +678,13 @@ describe("ChatView - DismissibleUpsell Display Tests", () => {
 			clineMessages: [], // No active task
 		})
 
-		// Should not show DismissibleUpsell when authenticated
 		expect(queryByTestId("dismissible-upsell")).not.toBeInTheDocument()
 	})
 
-	it("does not show DismissibleUpsell when user has only run 3 tasks in their history", () => {
+	it("shows RooTips when user has only run 3 tasks in their history", () => {
 		const { queryByTestId } = renderChatView()
 
-		// Hydrate state with user not authenticated but only 3 tasks
 		mockPostMessage({
-			cloudIsAuthenticated: false,
 			taskHistory: [
 				{ id: "1", ts: Date.now() - 2000 },
 				{ id: "2", ts: Date.now() - 1000 },
@@ -698,16 +693,14 @@ describe("ChatView - DismissibleUpsell Display Tests", () => {
 			clineMessages: [], // No active task
 		})
 
-		// Should not show DismissibleUpsell with less than 4 tasks
 		expect(queryByTestId("dismissible-upsell")).not.toBeInTheDocument()
+		expect(queryByTestId("roo-tips")).toBeInTheDocument()
 	})
 
-	it("shows DismissibleUpsell when user is not authenticated and has run 6 or more tasks", async () => {
-		const { getByTestId } = renderChatView()
+	it("does not show removed cloud upsell when user has run 6 or more tasks", async () => {
+		const { queryByTestId } = renderChatView()
 
-		// Hydrate state with user not authenticated and 4 tasks
 		mockPostMessage({
-			cloudIsAuthenticated: false,
 			taskHistory: [
 				{ id: "1", ts: Date.now() - 6000 },
 				{ id: "2", ts: Date.now() - 5000 },
@@ -720,18 +713,17 @@ describe("ChatView - DismissibleUpsell Display Tests", () => {
 			clineMessages: [], // No active task
 		})
 
-		// Wait for component to render and show DismissibleUpsell
 		await waitFor(() => {
-			expect(getByTestId("dismissible-upsell")).toBeInTheDocument()
+			expect(queryByTestId("dismissible-upsell")).not.toBeInTheDocument()
+			expect(queryByTestId("roo-tips")).not.toBeInTheDocument()
+			expect(queryByTestId("roo-hero")).toBeInTheDocument()
 		})
 	})
 
-	it("does not show DismissibleUpsell when there is an active task (regardless of auth status)", async () => {
+	it("does not show welcome content when there is an active task", async () => {
 		const { queryByTestId } = renderChatView()
 
-		// Hydrate state with active task
 		mockPostMessage({
-			cloudIsAuthenticated: false,
 			taskHistory: [
 				{ id: "1", ts: Date.now() - 3000 },
 				{ id: "2", ts: Date.now() - 2000 },
@@ -748,23 +740,17 @@ describe("ChatView - DismissibleUpsell Display Tests", () => {
 			],
 		})
 
-		// Wait for component to render with active task
 		await waitFor(() => {
-			// Should not show DismissibleUpsell during active task
 			expect(queryByTestId("dismissible-upsell")).not.toBeInTheDocument()
-			// Should not show RooTips either since the entire welcome screen is hidden during active tasks
 			expect(queryByTestId("roo-tips")).not.toBeInTheDocument()
-			// Should not show RooHero either since the entire welcome screen is hidden during active tasks
 			expect(queryByTestId("roo-hero")).not.toBeInTheDocument()
 		})
 	})
 
-	it("shows RooTips when user is authenticated (instead of DismissibleUpsell)", () => {
+	it("shows RooTips for newer users", () => {
 		const { queryByTestId, getByTestId } = renderChatView()
 
-		// Hydrate state with user authenticated to cloud
 		mockPostMessage({
-			cloudIsAuthenticated: true,
 			taskHistory: [
 				{ id: "1", ts: Date.now() - 3000 },
 				{ id: "2", ts: Date.now() - 2000 },
@@ -774,17 +760,14 @@ describe("ChatView - DismissibleUpsell Display Tests", () => {
 			clineMessages: [], // No active task
 		})
 
-		// Should not show DismissibleUpsell but should show RooTips
 		expect(queryByTestId("dismissible-upsell")).not.toBeInTheDocument()
 		expect(getByTestId("roo-tips")).toBeInTheDocument()
 	})
 
-	it("shows RooTips when user has fewer than 6 tasks (instead of DismissibleUpsell)", () => {
+	it("shows RooTips when user has fewer than 6 tasks", () => {
 		const { queryByTestId, getByTestId } = renderChatView()
 
-		// Hydrate state with user not authenticated but fewer than 4 tasks
 		mockPostMessage({
-			cloudIsAuthenticated: false,
 			taskHistory: [
 				{ id: "1", ts: Date.now() - 2000 },
 				{ id: "2", ts: Date.now() - 1000 },
@@ -793,7 +776,6 @@ describe("ChatView - DismissibleUpsell Display Tests", () => {
 			clineMessages: [], // No active task
 		})
 
-		// Should not show DismissibleUpsell but should show RooTips
 		expect(queryByTestId("dismissible-upsell")).not.toBeInTheDocument()
 		expect(getByTestId("roo-tips")).toBeInTheDocument()
 	})