fix(parser): add read_command_output to NativeToolCallParser

chore: remove terminalCompressProgressBar setting

- Fix: Add missing read_command_output case to parser (was causing 'Invalid arguments' errors)
- Remove: Delete compress progress bar setting from all components (redundant with preview size control)
- Clean up: Remove from global-settings, OutputInterceptor, BaseTerminal, ExecuteCommandTool, SettingsView, TerminalSettings, ExtensionStateContext
- Clean up: Remove from all i18n locale files

Author: hannesrudolph

packages/types/src/cloud.ts

@@ -99,7 +99,6 @@ export const organizationDefaultSettingsSchema = globalSettingsSchema
 		maxWorkspaceFiles: true,
 		showRooIgnoredFiles: true,
 		terminalCommandDelay: true,
-		terminalCompressProgressBar: true,
 		terminalOutputLineLimit: true,
 		terminalShellIntegrationDisabled: true,
 		terminalShellIntegrationTimeout: true,

packages/types/src/global-settings.ts

@@ -194,7 +194,6 @@ export const globalSettingsSchema = z.object({
 	terminalZshOhMy: z.boolean().optional(),
 	terminalZshP10k: z.boolean().optional(),
 	terminalZdotdir: z.boolean().optional(),
-	terminalCompressProgressBar: z.boolean().optional(),
 
 	diagnosticsEnabled: z.boolean().optional(),
 
@@ -384,7 +383,6 @@ export const EVALS_SETTINGS: RooCodeSettings = {
 	terminalZshClearEolMark: true,
 	terminalZshP10k: false,
 	terminalZdotdir: true,
-	terminalCompressProgressBar: true,
 	terminalShellIntegrationDisabled: true,
 
 	diagnosticsEnabled: true,

packages/types/src/vscode-extension-host.ts

@@ -313,7 +313,6 @@ export type ExtensionState = Pick<
 	| "terminalZshOhMy"
 	| "terminalZshP10k"
 	| "terminalZdotdir"
-	| "terminalCompressProgressBar"
 	| "diagnosticsEnabled"
 	| "language"
 	| "modeApiConfigs"

src/core/assistant-message/NativeToolCallParser.ts

@@ -790,6 +790,17 @@ export class NativeToolCallParser {
 					}
 					break
 
+				case "read_command_output":
+					if (args.artifact_id !== undefined) {
+						nativeArgs = {
+							artifact_id: args.artifact_id,
+							search: args.search,
+							offset: args.offset,
+							limit: args.limit,
+						} as NativeArgsFor<TName>
+					}
+					break
+
 				case "write_to_file":
 					if (args.path !== undefined && args.content !== undefined) {
 						nativeArgs = {

src/core/tools/ExecuteCommandTool.ts

@@ -211,15 +211,13 @@ export async function executeCommandInTerminal(
 		const providerState = await provider?.getState()
 		const terminalOutputPreviewSize =
 			providerState?.terminalOutputPreviewSize ?? DEFAULT_TERMINAL_OUTPUT_PREVIEW_SIZE
-		const terminalCompressProgressBar = providerState?.terminalCompressProgressBar ?? true
 
 		interceptor = new OutputInterceptor({
 			executionId,
 			taskId: task.taskId,
 			command,
 			storageDir,
 			previewSize: terminalOutputPreviewSize,
-			compressProgressBar: terminalCompressProgressBar,
 		})
 	}
 

src/core/webview/ClineProvider.ts

@@ -2048,7 +2048,6 @@ export class ClineProvider
 			maxReadFileLine,
 			maxImageFileSize,
 			maxTotalImageSize,
-			terminalCompressProgressBar,
 			historyPreviewCollapsed,
 			reasoningBlockCollapsed,
 			enterBehavior,
@@ -2196,7 +2195,6 @@ export class ClineProvider
 			maxTotalImageSize: maxTotalImageSize ?? 20,
 			maxConcurrentFileReads: maxConcurrentFileReads ?? 5,
 			settingsImportedAt: this.settingsImportedAt,
-			terminalCompressProgressBar: terminalCompressProgressBar ?? true,
 			hasSystemPromptOverride,
 			historyPreviewCollapsed: historyPreviewCollapsed ?? false,
 			reasoningBlockCollapsed: reasoningBlockCollapsed ?? true,
@@ -2415,7 +2413,6 @@ export class ClineProvider
 			terminalZshOhMy: stateValues.terminalZshOhMy ?? false,
 			terminalZshP10k: stateValues.terminalZshP10k ?? false,
 			terminalZdotdir: stateValues.terminalZdotdir ?? false,
-			terminalCompressProgressBar: stateValues.terminalCompressProgressBar ?? true,
 			mode: stateValues.mode ?? defaultModeSlug,
 			language: stateValues.language ?? formatLanguage(vscode.env.language),
 			mcpEnabled: stateValues.mcpEnabled ?? true,

src/core/webview/webviewMessageHandler.ts

@@ -631,10 +631,6 @@ export const webviewMessageHandler = async (
 						if (value !== undefined) {
 							Terminal.setTerminalZdotdir(value as boolean)
 						}
-					} else if (key === "terminalCompressProgressBar") {
-						if (value !== undefined) {
-							Terminal.setCompressProgressBar(value as boolean)
-						}
 					} else if (key === "mcpEnabled") {
 						newValue = value ?? true
 						const mcpHub = provider.getMcpHub()

src/integrations/terminal/BaseTerminal.ts

@@ -1,4 +1,4 @@
-import { truncateOutput, applyRunLengthEncoding, processBackspaces, processCarriageReturns } from "../misc/extract-text"
+import { truncateOutput, applyRunLengthEncoding } from "../misc/extract-text"
 import { DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT } from "@roo-code/types"
 
 import type {
@@ -162,7 +162,6 @@ export abstract class BaseTerminal implements RooTerminal {
 	private static terminalZshOhMy: boolean = false
 	private static terminalZshP10k: boolean = false
 	private static terminalZdotdir: boolean = false
-	private static compressProgressBar: boolean = true
 
 	/**
 	 * Compresses terminal output by applying run-length encoding and truncating to line limit
@@ -273,17 +272,10 @@ export abstract class BaseTerminal implements RooTerminal {
 	 * @returns The compressed terminal output
 	 */
 	public static compressTerminalOutput(input: string, lineLimit: number, characterLimit?: number): string {
-		let processedInput = input
-
-		if (BaseTerminal.compressProgressBar) {
-			processedInput = processCarriageReturns(processedInput)
-			processedInput = processBackspaces(processedInput)
-		}
-
 		// Default character limit to prevent context window explosion
 		const effectiveCharLimit = characterLimit ?? DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT
 
-		return truncateOutput(applyRunLengthEncoding(processedInput), lineLimit, effectiveCharLimit)
+		return truncateOutput(applyRunLengthEncoding(input), lineLimit, effectiveCharLimit)
 	}
 
 	/**
@@ -301,20 +293,4 @@ export abstract class BaseTerminal implements RooTerminal {
 	public static getTerminalZdotdir(): boolean {
 		return BaseTerminal.terminalZdotdir
 	}
-
-	/**
-	 * Sets whether to compress progress bar output by processing carriage returns
-	 * @param enabled Whether to enable progress bar compression
-	 */
-	public static setCompressProgressBar(enabled: boolean): void {
-		BaseTerminal.compressProgressBar = enabled
-	}
-
-	/**
-	 * Gets whether progress bar compression is enabled
-	 * @returns Whether progress bar compression is enabled
-	 */
-	public static getCompressProgressBar(): boolean {
-		return BaseTerminal.compressProgressBar
-	}
 }

src/integrations/terminal/OutputInterceptor.ts

@@ -3,8 +3,6 @@ import * as path from "path"
 
 import { TerminalOutputPreviewSize, TERMINAL_PREVIEW_BYTES, PersistedCommandOutput } from "@roo-code/types"
 
-import { processCarriageReturns, processBackspaces } from "../misc/extract-text"
-
 /**
  * Configuration options for creating an OutputInterceptor instance.
  */
@@ -19,8 +17,6 @@ export interface OutputInterceptorOptions {
 	storageDir: string
 	/** Size category for the preview buffer (small/medium/large) */
 	previewSize: TerminalOutputPreviewSize
-	/** Whether to compress progress bar output using carriage return processing */
-	compressProgressBar: boolean
 }
 
 /**
@@ -46,7 +42,6 @@ export interface OutputInterceptorOptions {
  *   command: 'npm test',
  *   storageDir: '/path/to/task/command-output',
  *   previewSize: 'medium',
- *   compressProgressBar: true
  * });
  *
  * // Write output chunks as they arrive
@@ -66,7 +61,6 @@ export class OutputInterceptor {
 	private totalBytes: number = 0
 	private spilledToDisk: boolean = false
 	private readonly previewBytes: number
-	private readonly compressProgressBar: boolean
 
 	/**
 	 * Creates a new OutputInterceptor instance.
@@ -75,7 +69,6 @@ export class OutputInterceptor {
 	 */
 	constructor(private readonly options: OutputInterceptorOptions) {
 		this.previewBytes = TERMINAL_PREVIEW_BYTES[options.previewSize]
-		this.compressProgressBar = options.compressProgressBar
 		this.artifactPath = path.join(options.storageDir, `cmd-${options.executionId}.txt`)
 	}
 
@@ -143,9 +136,6 @@ export class OutputInterceptor {
 	 * - The path to the full output file (if truncated)
 	 * - A flag indicating whether the output was truncated
 	 *
-	 * If `compressProgressBar` was enabled, the preview will have carriage returns
-	 * and backspaces processed to show only final line states.
-	 *
 	 * @returns The persisted command output summary
 	 *
 	 * @example
@@ -165,13 +155,7 @@ export class OutputInterceptor {
 		}
 
 		// Prepare preview
-		let preview = this.buffer.slice(0, this.previewBytes)
-
-		// Apply compression to preview only (for readability)
-		if (this.compressProgressBar) {
-			preview = processCarriageReturns(preview)
-			preview = processBackspaces(preview)
-		}
+		const preview = this.buffer.slice(0, this.previewBytes)
 
 		return {
 			preview,