Skip to content
This repository was archived by the owner on May 15, 2026. It is now read-only.

Commit 351fa14

Browse files
author
xk
committed
fix: address CI failures - unused import, missing mock, and translations
- Remove unused SkillLoadWarning import from SkillsSettings.tsx (lint warning) - Add getLoadWarnings mock to skillsMessageHandler.spec.ts (test failure) - Add loadWarnings translations to all 17 locale files (check-translations)
1 parent e397c22 commit 351fa14

19 files changed

Lines changed: 72 additions & 19 deletions

File tree

src/core/webview/__tests__/skillsMessageHandler.spec.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ describe("skillsMessageHandler", () => {
4747
const mockLog = vi.fn()
4848
const mockPostMessageToWebview = vi.fn()
4949
const mockGetSkillsMetadata = vi.fn()
50+
const mockGetLoadWarnings = vi.fn().mockReturnValue([])
5051
const mockCreateSkill = vi.fn()
5152
const mockDeleteSkill = vi.fn()
5253
const mockMoveSkill = vi.fn()
@@ -57,6 +58,7 @@ describe("skillsMessageHandler", () => {
5758
const skillsManager = hasSkillsManager
5859
? {
5960
getSkillsMetadata: mockGetSkillsMetadata,
61+
getLoadWarnings: mockGetLoadWarnings,
6062
createSkill: mockCreateSkill,
6163
deleteSkill: mockDeleteSkill,
6264
moveSkill: mockMoveSkill,
@@ -100,7 +102,7 @@ describe("skillsMessageHandler", () => {
100102
const result = await handleRequestSkills(provider)
101103

102104
expect(result).toEqual(mockSkills)
103-
expect(mockPostMessageToWebview).toHaveBeenCalledWith({ type: "skills", skills: mockSkills })
105+
expect(mockPostMessageToWebview).toHaveBeenCalledWith({ type: "skills", skills: mockSkills, skillLoadWarnings: [] })
104106
})
105107

106108
it("returns empty skills when skills manager is not available", async () => {

webview-ui/src/components/settings/SkillsSettings.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React, { useState, useEffect, useMemo, useCallback } from "react"
22
import { Plus, Globe, Folder, Edit, Trash2, Settings, AlertTriangle, ChevronDown, ChevronRight } from "lucide-react"
33
import { Trans } from "react-i18next"
44

5-
import type { SkillMetadata, SkillLoadWarning } from "@roo-code/types"
5+
import type { SkillMetadata } from "@roo-code/types"
66

77
import { getAllModes } from "@roo/modes"
88

webview-ui/src/i18n/locales/ca/settings.json

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/de/settings.json

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/es/settings.json

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/fr/settings.json

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/hi/settings.json

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/id/settings.json

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/it/settings.json

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/ja/settings.json

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)