Skip to content
This repository was archived by the owner on May 15, 2026. It is now read-only.

Commit 770b071

Browse files
committed
fix(settings): default reasoning effort from model definition
Models with supportsReasoningEffort as an array (e.g., gpt-5.2) and no requiredReasoningEffort would show a blank dropdown because the default fell to 'disable' which wasn't in the available options. Now uses the model's declared reasoningEffort as the default.
1 parent da10b71 commit 770b071

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

webview-ui/src/components/settings/ThinkingBudget.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ export const ThinkingBudget = ({ apiConfiguration, setApiConfigurationField, mod
103103
const modelDefaultReasoningEffort = modelInfo?.reasoningEffort as ReasoningEffortWithMinimal | undefined
104104
const defaultReasoningEffort: ReasoningEffortOption = modelInfo?.requiredReasoningEffort
105105
? modelDefaultReasoningEffort || "medium"
106-
: "disable"
106+
: modelDefaultReasoningEffort || "disable"
107107
// Current reasoning effort from settings, or fall back to default
108108
const storedReasoningEffort = apiConfiguration.reasoningEffort as ReasoningEffortOption | undefined
109109
const currentReasoningEffort: ReasoningEffortOption = storedReasoningEffort || defaultReasoningEffort
@@ -112,7 +112,7 @@ export const ThinkingBudget = ({ apiConfiguration, setApiConfigurationField, mod
112112
useEffect(() => {
113113
if (isReasoningEffortSupported && !apiConfiguration.reasoningEffort) {
114114
// Only set a default if reasoning is required, otherwise leave as undefined (which maps to "disable")
115-
if (modelInfo?.requiredReasoningEffort && defaultReasoningEffort !== "disable") {
115+
if (defaultReasoningEffort !== "disable") {
116116
setApiConfigurationField("reasoningEffort", defaultReasoningEffort as ReasoningEffortWithMinimal, false)
117117
}
118118
}

0 commit comments

Comments
 (0)