|
1 | | -Cherry-pick feasibility analysis complete. |
2 | | -42/42 PRs analyzed via dry-run cherry-pick. |
3 | | -Plan document: docs/reapplication-plan.md |
4 | | -Analysis date: 2026-02-14 |
| 1 | +# Reapplication Progress |
5 | 2 |
|
6 | | -## Batch 1 — COMPLETE (2026-02-14) |
7 | | -- 22/22 clean cherry-picks applied |
8 | | -- PR #11473 created: https://github.com/RooCodeInc/Roo-Code/pull/11473 |
9 | | -- Branch: reapply/batch-1-clean-cherry-picks |
10 | | -- Extra fix: maxReadFileLine added to ExtensionState type |
11 | | -- Empty commits: #11215, #11410 (already present in base) |
12 | | -- Verification: 5,359 backend tests ✅, 1,229 webview-ui tests ✅, TypeScript ✅ |
| 3 | +## Batch 1: Clean Cherry-Picks (22 PRs) |
| 4 | +Status: COMPLETE — merged via PR #11473 |
13 | 5 |
|
14 | | -### Detailed Results: 22/22 PRs successfully cherry-picked |
| 6 | +## Batch 2: Minor Conflicts (13 PRs) |
| 7 | +Status: COMPLETE — 12/13 cherry-picked, 1 skipped |
| 8 | +Branch: reapply/batch-2-minor-conflicts |
15 | 9 |
|
16 | | -| Order | PR# | Commit SHA | New SHA | Status | |
17 | | -|-------|------|------------|---------|--------| |
18 | | -| 1 | #10874 | e46fae7ad7 | e597921478 | ✅ | |
19 | | -| 2 | #10975 | b4b8cef859 | a357c00e35 | ✅ | |
20 | | -| 3 | #10981 | cc86049f10 | 08f2fe23a5 | ✅ | |
21 | | -| 4 | #10994 | fa93109b76 | 10d9577a61 | ✅ | |
22 | | -| 5 | #11038 | 1e790b0d39 | db11712d17 | ✅ | |
23 | | -| 6 | #11116 | 20d1f1f282 | 9d2907fa4c | ✅ | |
24 | | -| 7 | #11131 | 3400499917 | fc71291e71 | ✅ | |
25 | | -| 8 | #11140 | ede1d29299 | 196d0d6720 | ✅ | |
26 | | -| 9 | #11162 | e5fa5e8e46 | 61edbb34c6 | ✅ | |
27 | | -| 10 | #11183 | 1da2b1c457 | 6a562c09c1 | ✅ | |
28 | | -| 11 | #11205 | aa49871a5d | 6fbb60cb9c | ✅ | |
29 | | -| 12 | #11207 | f73b103b87 | bd3fbe7608 | ✅ | |
30 | | -| 13 | #11215 | 5507f5ab64 | eae9c966b5 | ✅ (empty commit) | |
31 | | -| 14 | #11224 | 47bba1c2f7 | a45e9cc4d6 | ✅ | |
32 | | -| 15 | #11225 | d5b7fdcfa7 | c24b9b48ab | ✅ | |
33 | | -| 16 | #11281 | 6826e20da2 | a50adc786a | ✅ | |
34 | | -| 17 | #11302 | 70775f0ec1 | 94e1f07be2 | ✅ | |
35 | | -| 18 | #11313 | 62a0106ce0 | 21f6c31258 | ✅ | |
36 | | -| 19 | #11331 | 7c58f29975 | 87cee09491 | ✅ | |
37 | | -| 20 | #11335 | 115d6c5fce | 761bef443d | ✅ | |
38 | | -| 21 | #11369 | b02924530c | b2340d7ce0 | ✅ | |
39 | | -| 22 | #11410 | d2c52c9e09 | eb23efd7cf | ✅ (empty commit) | |
| 10 | +### Cherry-Picked (12): |
| 11 | +| Order | PR# | Title | Status | |
| 12 | +|---|---|---|---| |
| 13 | +| 1 | #11232 | Bedrock model ID for Opus 4.6 | ✅ Clean | |
| 14 | +| 2 | #11233 | empty-string baseURL guard | ✅ Resolved (3 conflicts - pre-AI-SDK provider pattern) | |
| 15 | +| 3 | #11218 | defaultTemperature required in getModelParams | ✅ Resolved (2 conflicts + manual fixes for xai.ts, vertex.ts) | |
| 16 | +| 4 | #11245 | batch consecutive tool calls in chat UI | ✅ Resolved (1 conflict - ChatRow.tsx) | |
| 17 | +| 5 | #11279 | IPC query handlers | ✅ Clean | |
| 18 | +| 6 | #11295 | lock toggle to pin API config | ✅ Resolved (1 conflict - pnpm-lock.yaml) | |
| 19 | +| 7 | #11303 | Gemini thinkingLevel validation | ✅ Resolved (3 hunks in gemini.ts - pre-AI-SDK) | |
| 20 | +| 8 | #11374 | Azure Foundry fix | ⏭️ SKIPPED — azure files don't exist, depends on #11315 (Batch 5) | |
| 21 | +| 9 | #11379 | harden delegation lifecycle | ✅ Resolved (11 hunks across 5 files - RooMessage API) | |
| 22 | +| 10 | #11418 | delegation reopen flow | ✅ Resolved (6 hunks across 2 files) | |
| 23 | +| 11 | #11422 | cancel/resume abort races | ✅ Resolved (1 conflict - Task.ts) | |
| 24 | +| 12 | #11425 | cli release v0.0.53 | ✅ Resolved (2 conflicts - version bump) | |
| 25 | +| 13 | #11440 | GLM-5 model for Z.ai | ✅ Resolved (2 conflicts - pre-AI-SDK zai.ts) | |
40 | 26 |
|
41 | | -### Notes |
42 | | -- #11215 and #11410 were empty commits (changes already present in base) |
43 | | -- Delegation chain (#11281 → #11302 → #11331 → #11335) applied cleanly in order |
44 | | -- Several auto-merges resolved automatically (no manual intervention needed) |
| 27 | +### Post-Cherry-Pick Fixes: |
| 28 | +- Created rooMessage.ts (standalone types, no AI SDK dependency) |
| 29 | +- Fixed ClineProvider.ts syntax error (orphaned try/finally from merge) |
| 30 | +- Rewrote 3 gemini.spec.ts tests from AI-SDK to pre-AI-SDK mock pattern |
| 31 | +- Added saveDelegationMeta mock to history-resume-delegation.spec.ts |
45 | 32 |
|
46 | | -## Next: Batch 2 (13 minor conflict PRs) |
47 | | -## Blocked: Batches 3-4 (product decisions needed) |
48 | | -## Pending: Batch 5 (Azure Foundry reimplementation) |
| 33 | +### Validation: |
| 34 | +- pnpm check-types: 14/14 passed |
| 35 | +- Backend tests: 378 files, 5403 tests passed |
| 36 | +- Webview-UI tests: 120 files, 1250 tests passed |
| 37 | + |
| 38 | +### Key Learnings: |
| 39 | +- Pre-AI-SDK provider conflicts: always keep HEAD, apply only intent |
| 40 | +- AI-SDK test mocks (mockStreamText) must be rewritten to pre-AI-SDK pattern (generateContentStream/mockCreate) |
| 41 | +- "Accept theirs" during cherry-pick can include BOTH sides of conflict, creating duplicates |
| 42 | +- rooMessage.ts from source imports from "ai" package — need standalone version for pre-AI-SDK |
| 43 | + |
| 44 | +## Batch 3-5: Pending |
0 commit comments