refactor: remove terminalOutputLineLimit and terminalOutputCharacterLimit settings

These settings were redundant with terminalOutputPreviewSize which controls
the preview shown to the LLM. The line/char limits were for UI truncation
which is now handled with hardcoded defaults (500 lines, 50K chars) since
they don't need to be user-configurable.

- Remove settings from packages/types schemas
- Remove DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT constant
- Update compressTerminalOutput() to use hardcoded limits
- Update ExecuteCommandTool to not pass limit parameters
- Update ClineProvider state handling
- Update webview context and settings
- Update tests to not use removed settings

Author: hannesrudolph

packages/types/src/cloud.ts

@@ -99,7 +99,6 @@ export const organizationDefaultSettingsSchema = globalSettingsSchema
 		maxWorkspaceFiles: true,
 		showRooIgnoredFiles: true,
 		terminalCommandDelay: true,
-		terminalOutputLineLimit: true,
 		terminalShellIntegrationDisabled: true,
 		terminalShellIntegrationTimeout: true,
 		terminalZshClearEolMark: true,
@@ -111,7 +110,6 @@ export const organizationDefaultSettingsSchema = globalSettingsSchema
 			maxReadFileLine: z.number().int().gte(-1).optional(),
 			maxWorkspaceFiles: z.number().int().nonnegative().optional(),
 			terminalCommandDelay: z.number().int().nonnegative().optional(),
-			terminalOutputLineLimit: z.number().int().nonnegative().optional(),
 			terminalShellIntegrationTimeout: z.number().int().nonnegative().optional(),
 		}),
 	)

packages/types/src/global-settings.ts

@@ -22,13 +22,6 @@ import { languagesSchema } from "./vscode.js"
  */
 export const DEFAULT_WRITE_DELAY_MS = 1000
 
-/**
- * Default terminal output character limit constant.
- * This provides a reasonable default that aligns with typical terminal usage
- * while preventing context window explosions from extremely long lines.
- */
-export const DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT = 50_000
-
 /**
  * Terminal output preview size options for persisted command output.
  *
@@ -183,8 +176,6 @@ export const globalSettingsSchema = z.object({
 	maxImageFileSize: z.number().optional(),
 	maxTotalImageSize: z.number().optional(),
 
-	terminalOutputLineLimit: z.number().optional(),
-	terminalOutputCharacterLimit: z.number().optional(),
 	terminalOutputPreviewSize: z.enum(["small", "medium", "large"]).optional(),
 	terminalShellIntegrationTimeout: z.number().optional(),
 	terminalShellIntegrationDisabled: z.boolean().optional(),
@@ -374,8 +365,6 @@ export const EVALS_SETTINGS: RooCodeSettings = {
 	soundEnabled: false,
 	soundVolume: 0.5,
 
-	terminalOutputLineLimit: 500,
-	terminalOutputCharacterLimit: DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT,
 	terminalShellIntegrationTimeout: 30000,
 	terminalCommandDelay: 0,
 	terminalPowershellCounter: false,

packages/types/src/vscode-extension-host.ts

@@ -302,8 +302,6 @@ export type ExtensionState = Pick<
 	| "soundEnabled"
 	| "soundVolume"
 	| "maxConcurrentFileReads"
-	| "terminalOutputLineLimit"
-	| "terminalOutputCharacterLimit"
 	| "terminalOutputPreviewSize"
 	| "terminalShellIntegrationTimeout"
 	| "terminalShellIntegrationDisabled"

src/core/environment/getEnvironmentDetails.ts

@@ -6,7 +6,6 @@ import pWaitFor from "p-wait-for"
 import delay from "delay"
 
 import type { ExperimentId } from "@roo-code/types"
-import { DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT } from "@roo-code/types"
 
 import { formatLanguage } from "../../shared/language"
 import { defaultModeSlug, getFullModeDetails } from "../../shared/modes"
@@ -26,11 +25,7 @@ export async function getEnvironmentDetails(cline: Task, includeFileDetails: boo
 
 	const clineProvider = cline.providerRef.deref()
 	const state = await clineProvider?.getState()
-	const {
-		terminalOutputLineLimit = 500,
-		terminalOutputCharacterLimit = DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT,
-		maxWorkspaceFiles = 200,
-	} = state ?? {}
+	const { maxWorkspaceFiles = 200 } = state ?? {}
 
 	// It could be useful for cline to know if the user went from one or no
 	// file to another between messages, so we always include this context.
@@ -112,11 +107,7 @@ export async function getEnvironmentDetails(cline: Task, includeFileDetails: boo
 			let newOutput = TerminalRegistry.getUnretrievedOutput(busyTerminal.id)
 
 			if (newOutput) {
-				newOutput = Terminal.compressTerminalOutput(
-					newOutput,
-					terminalOutputLineLimit,
-					terminalOutputCharacterLimit,
-				)
+				newOutput = Terminal.compressTerminalOutput(newOutput)
 				terminalDetails += `\n### New Output\n${newOutput}`
 			}
 		}
@@ -144,11 +135,7 @@ export async function getEnvironmentDetails(cline: Task, includeFileDetails: boo
 				let output = process.getUnretrievedOutput()
 
 				if (output) {
-					output = Terminal.compressTerminalOutput(
-						output,
-						terminalOutputLineLimit,
-						terminalOutputCharacterLimit,
-					)
+					output = Terminal.compressTerminalOutput(output)
 					terminalOutputs.push(`Command: \`${process.command}\`\n${output}`)
 				}
 			}

src/core/tools/ExecuteCommandTool.ts

@@ -4,12 +4,7 @@ import * as vscode from "vscode"
 
 import delay from "delay"
 
-import {
-	CommandExecutionStatus,
-	DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT,
-	DEFAULT_TERMINAL_OUTPUT_PREVIEW_SIZE,
-	PersistedCommandOutput,
-} from "@roo-code/types"
+import { CommandExecutionStatus, DEFAULT_TERMINAL_OUTPUT_PREVIEW_SIZE, PersistedCommandOutput } from "@roo-code/types"
 import { TelemetryService } from "@roo-code/telemetry"
 
 import { Task } from "../task/Task"
@@ -69,11 +64,7 @@ export class ExecuteCommandTool extends BaseTool<"execute_command"> {
 			const provider = await task.providerRef.deref()
 			const providerState = await provider?.getState()
 
-			const {
-				terminalOutputLineLimit = 500,
-				terminalOutputCharacterLimit = DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT,
-				terminalShellIntegrationDisabled = true,
-			} = providerState ?? {}
+			const { terminalShellIntegrationDisabled = true } = providerState ?? {}
 
 			// Get command execution timeout from VSCode configuration (in seconds)
 			const commandExecutionTimeoutSeconds = vscode.workspace
@@ -98,8 +89,6 @@ export class ExecuteCommandTool extends BaseTool<"execute_command"> {
 				command: unescapedCommand,
 				customCwd,
 				terminalShellIntegrationDisabled,
-				terminalOutputLineLimit,
-				terminalOutputCharacterLimit,
 				commandExecutionTimeout,
 			}
 
@@ -153,8 +142,6 @@ export type ExecuteCommandOptions = {
 	command: string
 	customCwd?: string
 	terminalShellIntegrationDisabled?: boolean
-	terminalOutputLineLimit?: number
-	terminalOutputCharacterLimit?: number
 	commandExecutionTimeout?: number
 }
 
@@ -165,8 +152,6 @@ export async function executeCommandInTerminal(
 		command,
 		customCwd,
 		terminalShellIntegrationDisabled = true,
-		terminalOutputLineLimit = 500,
-		terminalOutputCharacterLimit = DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT,
 		commandExecutionTimeout = 0,
 	}: ExecuteCommandOptions,
 ): Promise<[boolean, ToolResponse]> {
@@ -223,8 +208,8 @@ export async function executeCommandInTerminal(
 
 	let accumulatedOutput = ""
 	// Bound accumulated output buffer size to prevent unbounded memory growth for long-running commands.
-	// The interceptor preserves full output; this buffer is only for UI display.
-	const maxAccumulatedOutputSize = terminalOutputCharacterLimit * 2
+	// The interceptor preserves full output; this buffer is only for UI display (100KB limit).
+	const maxAccumulatedOutputSize = 100_000
 	const callbacks: RooTerminalCallbacks = {
 		onLine: async (lines: string, process: RooTerminalProcess) => {
 			accumulatedOutput += lines
@@ -238,11 +223,7 @@ export async function executeCommandInTerminal(
 			interceptor?.write(lines)
 
 			// Continue sending compressed output to webview for UI display (unchanged behavior)
-			const compressedOutput = Terminal.compressTerminalOutput(
-				accumulatedOutput,
-				terminalOutputLineLimit,
-				terminalOutputCharacterLimit,
-			)
+			const compressedOutput = Terminal.compressTerminalOutput(accumulatedOutput)
 			const status: CommandExecutionStatus = { executionId, status: "output", output: compressedOutput }
 			provider?.postMessageToWebview({ type: "commandExecutionStatus", text: JSON.stringify(status) })
 
@@ -272,11 +253,7 @@ export async function executeCommandInTerminal(
 			}
 
 			// Continue using compressed output for UI display
-			result = Terminal.compressTerminalOutput(
-				output ?? "",
-				terminalOutputLineLimit,
-				terminalOutputCharacterLimit,
-			)
+			result = Terminal.compressTerminalOutput(output ?? "")
 
 			task.say("command_output", result)
 			completed = true

src/core/tools/__tests__/executeCommand.spec.ts

@@ -40,7 +40,6 @@ describe("executeCommand", () => {
 		mockProvider = {
 			postMessageToWebview: vitest.fn(),
 			getState: vitest.fn().mockResolvedValue({
-				terminalOutputLineLimit: 500,
 				terminalShellIntegrationDisabled: false,
 			}),
 		}
@@ -100,7 +99,6 @@ describe("executeCommand", () => {
 				executionId: "test-123",
 				command: "echo test",
 				terminalShellIntegrationDisabled: false,
-				terminalOutputLineLimit: 500,
 			}
 
 			// Execute
@@ -141,7 +139,6 @@ describe("executeCommand", () => {
 				executionId: "test-123",
 				command: "echo test",
 				terminalShellIntegrationDisabled: false,
-				terminalOutputLineLimit: 500,
 			}
 
 			// Execute
@@ -174,7 +171,6 @@ describe("executeCommand", () => {
 				executionId: "test-123",
 				command: "echo test",
 				terminalShellIntegrationDisabled: true, // Forces ExecaTerminal
-				terminalOutputLineLimit: 500,
 			}
 
 			// Execute
@@ -205,7 +201,6 @@ describe("executeCommand", () => {
 				command: "echo test",
 				customCwd,
 				terminalShellIntegrationDisabled: false,
-				terminalOutputLineLimit: 500,
 			}
 
 			// Execute
@@ -235,7 +230,6 @@ describe("executeCommand", () => {
 				command: "echo test",
 				customCwd: relativeCwd,
 				terminalShellIntegrationDisabled: false,
-				terminalOutputLineLimit: 500,
 			}
 
 			// Execute
@@ -258,7 +252,6 @@ describe("executeCommand", () => {
 				command: "echo test",
 				customCwd: nonExistentCwd,
 				terminalShellIntegrationDisabled: false,
-				terminalOutputLineLimit: 500,
 			}
 
 			// Execute
@@ -285,7 +278,6 @@ describe("executeCommand", () => {
 				executionId: "test-123",
 				command: "echo test",
 				terminalShellIntegrationDisabled: false,
-				terminalOutputLineLimit: 500,
 			}
 
 			// Execute
@@ -308,7 +300,6 @@ describe("executeCommand", () => {
 				executionId: "test-123",
 				command: "echo test",
 				terminalShellIntegrationDisabled: true,
-				terminalOutputLineLimit: 500,
 			}
 
 			// Execute
@@ -334,7 +325,6 @@ describe("executeCommand", () => {
 				executionId: "test-123",
 				command: "echo success",
 				terminalShellIntegrationDisabled: false,
-				terminalOutputLineLimit: 500,
 			}
 
 			// Execute
@@ -360,7 +350,6 @@ describe("executeCommand", () => {
 				executionId: "test-123",
 				command: "exit 1",
 				terminalShellIntegrationDisabled: false,
-				terminalOutputLineLimit: 500,
 			}
 
 			// Execute
@@ -394,7 +383,6 @@ describe("executeCommand", () => {
 				executionId: "test-123",
 				command: "long-running-command",
 				terminalShellIntegrationDisabled: false,
-				terminalOutputLineLimit: 500,
 			}
 
 			// Execute
@@ -436,7 +424,6 @@ describe("executeCommand", () => {
 				executionId: "test-123",
 				command: "cd src && pwd",
 				terminalShellIntegrationDisabled: false,
-				terminalOutputLineLimit: 500,
 			}
 
 			// Execute

src/core/webview/ClineProvider.ts

@@ -40,7 +40,6 @@ import {
 	RooCodeEventName,
 	requestyDefaultModelId,
 	openRouterDefaultModelId,
-	DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT,
 	DEFAULT_WRITE_DELAY_MS,
 	ORGANIZATION_ALLOW_ALL,
 	DEFAULT_MODES,
@@ -2016,8 +2015,6 @@ export class ClineProvider
 			remoteBrowserEnabled,
 			cachedChromeHostUrl,
 			writeDelayMs,
-			terminalOutputLineLimit,
-			terminalOutputCharacterLimit,
 			terminalShellIntegrationTimeout,
 			terminalShellIntegrationDisabled,
 			terminalCommandDelay,
@@ -2156,8 +2153,6 @@ export class ClineProvider
 			remoteBrowserEnabled: remoteBrowserEnabled ?? false,
 			cachedChromeHostUrl: cachedChromeHostUrl,
 			writeDelayMs: writeDelayMs ?? DEFAULT_WRITE_DELAY_MS,
-			terminalOutputLineLimit: terminalOutputLineLimit ?? 500,
-			terminalOutputCharacterLimit: terminalOutputCharacterLimit ?? DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT,
 			terminalShellIntegrationTimeout: terminalShellIntegrationTimeout ?? Terminal.defaultShellIntegrationTimeout,
 			terminalShellIntegrationDisabled: terminalShellIntegrationDisabled ?? true,
 			terminalCommandDelay: terminalCommandDelay ?? 0,
@@ -2401,9 +2396,6 @@ export class ClineProvider
 			remoteBrowserEnabled: stateValues.remoteBrowserEnabled ?? false,
 			cachedChromeHostUrl: stateValues.cachedChromeHostUrl as string | undefined,
 			writeDelayMs: stateValues.writeDelayMs ?? DEFAULT_WRITE_DELAY_MS,
-			terminalOutputLineLimit: stateValues.terminalOutputLineLimit ?? 500,
-			terminalOutputCharacterLimit:
-				stateValues.terminalOutputCharacterLimit ?? DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT,
 			terminalShellIntegrationTimeout:
 				stateValues.terminalShellIntegrationTimeout ?? Terminal.defaultShellIntegrationTimeout,
 			terminalShellIntegrationDisabled: stateValues.terminalShellIntegrationDisabled ?? true,

src/integrations/terminal/BaseTerminal.ts

@@ -1,5 +1,4 @@
 import { truncateOutput, applyRunLengthEncoding } from "../misc/extract-text"
-import { DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT } from "@roo-code/types"
 
 import type {
 	RooTerminalProvider,
@@ -265,17 +264,19 @@ export abstract class BaseTerminal implements RooTerminal {
 	}
 
 	/**
-	 * Compresses terminal output by applying run-length encoding and truncating to line and character limits
+	 * Compresses terminal output by applying run-length encoding and truncating to reasonable limits.
+	 * Uses hardcoded defaults: 500 lines, 50K characters - these are UI display limits to prevent
+	 * memory issues, not LLM context limits (which are controlled by terminalOutputPreviewSize).
 	 * @param input The terminal output to compress
-	 * @param lineLimit Maximum number of lines to keep
-	 * @param characterLimit Optional maximum number of characters to keep (defaults to DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT)
 	 * @returns The compressed terminal output
 	 */
-	public static compressTerminalOutput(input: string, lineLimit: number, characterLimit?: number): string {
-		// Default character limit to prevent context window explosion
-		const effectiveCharLimit = characterLimit ?? DEFAULT_TERMINAL_OUTPUT_CHARACTER_LIMIT
+	public static compressTerminalOutput(input: string): string {
+		// Hardcoded UI display limits - these prevent unbounded memory growth
+		// in the chat display, separate from the LLM context limits
+		const LINE_LIMIT = 500
+		const CHARACTER_LIMIT = 50_000
 
-		return truncateOutput(applyRunLengthEncoding(input), lineLimit, effectiveCharLimit)
+		return truncateOutput(applyRunLengthEncoding(input), LINE_LIMIT, CHARACTER_LIMIT)
 	}
 
 	/**

webview-ui/src/components/settings/SettingsView.tsx

@@ -179,8 +179,6 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t
 		ttsSpeed,
 		soundVolume,
 		telemetrySetting,
-		terminalOutputLineLimit,
-		terminalOutputCharacterLimit,
 		terminalOutputPreviewSize,
 		terminalShellIntegrationTimeout,
 		terminalShellIntegrationDisabled, // Added from upstream
@@ -391,8 +389,6 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t
 					remoteBrowserEnabled: remoteBrowserEnabled ?? false,
 					writeDelayMs,
 					screenshotQuality: screenshotQuality ?? 75,
-					terminalOutputLineLimit: terminalOutputLineLimit ?? 500,
-					terminalOutputCharacterLimit: terminalOutputCharacterLimit ?? 50_000,
 					terminalShellIntegrationTimeout: terminalShellIntegrationTimeout ?? 30_000,
 					terminalShellIntegrationDisabled,
 					terminalCommandDelay,