Refactor: Remove line_count parameter from write_to_file tool (#9667)

Author: hannesrudolph

src/core/assistant-message/NativeToolCallParser.ts

@@ -394,16 +394,10 @@ export class NativeToolCallParser {
 				break
 
 			case "write_to_file":
-				if (partialArgs.path || partialArgs.content || partialArgs.line_count !== undefined) {
+				if (partialArgs.path || partialArgs.content) {
 					nativeArgs = {
 						path: partialArgs.path,
 						content: partialArgs.content,
-						line_count:
-							typeof partialArgs.line_count === "number"
-								? partialArgs.line_count
-								: partialArgs.line_count
-									? parseInt(String(partialArgs.line_count), 10)
-									: undefined,
 					}
 				}
 				break
@@ -745,14 +739,10 @@ export class NativeToolCallParser {
 					break
 
 				case "write_to_file":
-					if (args.path !== undefined && args.content !== undefined && args.line_count !== undefined) {
+					if (args.path !== undefined && args.content !== undefined) {
 						nativeArgs = {
 							path: args.path,
 							content: args.content,
-							line_count:
-								typeof args.line_count === "number"
-									? args.line_count
-									: parseInt(String(args.line_count), 10),
 						} as NativeArgsFor<TName>
 					}
 					break

src/core/assistant-message/__tests__/AssistantMessageParser.spec.ts

@@ -179,7 +179,7 @@ describe("AssistantMessageParser (streaming)", () => {
 	// This has XML-like content: </content>
 	return true;
 	}
-	</content><line_count>5</line_count></write_to_file>`
+	</content></write_to_file>`
 
 			const result = streamChunks(parser, message).filter((block) => !isEmptyTextContent(block))
 
@@ -188,7 +188,6 @@ describe("AssistantMessageParser (streaming)", () => {
 			expect(toolUse.type).toBe("tool_use")
 			expect(toolUse.name).toBe("write_to_file")
 			expect(toolUse.params.path).toBe("src/file.ts")
-			expect(toolUse.params.line_count).toBe("5")
 			expect(toolUse.params.content).toContain("function example()")
 			expect(toolUse.params.content).toContain("// This has XML-like content: </content>")
 			expect(toolUse.params.content).toContain("return true;")
@@ -263,7 +262,7 @@ describe("AssistantMessageParser (streaming)", () => {
 	line 1
 	line 2
 	line 3
-	</content><line_count>3</line_count></write_to_file>`
+	</content></write_to_file>`
 			const result = streamChunks(parser, message).filter((block) => !isEmptyTextContent(block))
 
 			expect(result).toHaveLength(1)
@@ -274,7 +273,6 @@ describe("AssistantMessageParser (streaming)", () => {
 			expect(toolUse.params.content).toContain("line 1")
 			expect(toolUse.params.content).toContain("line 2")
 			expect(toolUse.params.content).toContain("line 3")
-			expect(toolUse.params.line_count).toBe("3")
 			expect(toolUse.partial).toBe(false)
 		})
 		it("should handle a complex message with multiple content types", () => {
@@ -287,7 +285,7 @@ describe("AssistantMessageParser (streaming)", () => {
 	<write_to_file><path>src/index.ts</path><content>
 	// Updated content
 	console.log("Hello world");
-	</content><line_count>2</line_count></write_to_file>
+	</content></write_to_file>
 
 	Let's run the code:
 

src/core/assistant-message/__tests__/parseAssistantMessage.spec.ts

@@ -168,7 +168,7 @@ const isEmptyTextContent = (block: AssistantMessageContent) =>
 	// This has XML-like content: </content>
 	return true;
 	}
-	</content><line_count>5</line_count></write_to_file>`
+	</content></write_to_file>`
 
 				const result = parser(message).filter((block) => !isEmptyTextContent(block))
 
@@ -177,7 +177,6 @@ const isEmptyTextContent = (block: AssistantMessageContent) =>
 				expect(toolUse.type).toBe("tool_use")
 				expect(toolUse.name).toBe("write_to_file")
 				expect(toolUse.params.path).toBe("src/file.ts")
-				expect(toolUse.params.line_count).toBe("5")
 				expect(toolUse.params.content).toContain("function example()")
 				expect(toolUse.params.content).toContain("// This has XML-like content: </content>")
 				expect(toolUse.params.content).toContain("return true;")
@@ -276,7 +275,7 @@ const isEmptyTextContent = (block: AssistantMessageContent) =>
 	line 1
 	line 2
 	line 3
-	</content><line_count>3</line_count></write_to_file>`
+	</content></write_to_file>`
 				const result = parser(message).filter((block) => !isEmptyTextContent(block))
 
 				expect(result).toHaveLength(1)
@@ -287,7 +286,6 @@ const isEmptyTextContent = (block: AssistantMessageContent) =>
 				expect(toolUse.params.content).toContain("line 1")
 				expect(toolUse.params.content).toContain("line 2")
 				expect(toolUse.params.content).toContain("line 3")
-				expect(toolUse.params.line_count).toBe("3")
 				expect(toolUse.partial).toBe(false)
 			})
 
@@ -301,7 +299,7 @@ const isEmptyTextContent = (block: AssistantMessageContent) =>
 	<write_to_file><path>src/index.ts</path><content>
 	// Updated content
 	console.log("Hello world");
-	</content><line_count>2</line_count></write_to_file>
+	</content></write_to_file>
 
 	Let's run the code:
 

src/core/assistant-message/__tests__/parseAssistantMessageBenchmark.ts

@@ -62,17 +62,17 @@ const testCases = [
 	},
 	{
 		name: "Message with a complex tool use (write_to_file)",
-		input: "<write_to_file><path>src/file.ts</path><content>\nfunction example() {\n  // This has XML-like content: </content>\n  return true;\n}\n</content><line_count>5</line_count></write_to_file>",
+		input: "<write_to_file><path>src/file.ts</path><content>\nfunction example() {\n  // This has XML-like content: </content>\n  return true;\n}\n</content></write_to_file>",
 	},
 	{
 		name: "Message with multiple tool uses",
-		input: "First file: <read_file><path>src/file1.ts</path></read_file>\nSecond file: <read_file><path>src/file2.ts</path></read_file>\nLet's write a new file: <write_to_file><path>src/file3.ts</path><content>\nexport function newFunction() {\n  return 'Hello world';\n}\n</content><line_count>3</line_count></write_to_file>",
+		input: "First file: <read_file><path>src/file1.ts</path></read_file>\nSecond file: <read_file><path>src/file2.ts</path></read_file>\nLet's write a new file: <write_to_file><path>src/file3.ts</path><content>\nexport function newFunction() {\n  return 'Hello world';\n}\n</content></write_to_file>",
 	},
 	{
 		name: "Large message with repeated tool uses",
 		input: Array(50)
 			.fill(
-				'<read_file><path>src/file.ts</path></read_file>\n<write_to_file><path>output.ts</path><content>console.log("hello");</content><line_count>1</line_count></write_to_file>',
+				'<read_file><path>src/file.ts</path></read_file>\n<write_to_file><path>output.ts</path><content>console.log("hello");</content></write_to_file>',
 			)
 			.join("\n"),
 	},