refactor: improve code quality in condense module

- Convert summarizeConversation to use options object instead of 11 positional params
- Extract duplicated getFilesReadByRoo error handling into helper method
- Remove unnecessary re-export of generateFoldedFileContext
- Update all test files to use new options object pattern

Author: daniel-lxs

src/core/condense/__tests__/condense.spec.ts

@@ -136,7 +136,13 @@ Line 2
 				{ role: "user", content: "Ninth message" },
 			]
 
-			const result = await summarizeConversation(messages, mockApiHandler, "System prompt", taskId, false)
+			const result = await summarizeConversation({
+				messages,
+				apiHandler: mockApiHandler,
+				systemPrompt: "System prompt",
+				taskId,
+				isAutomaticTrigger: false,
+			})
 
 			// Verify we have a summary message with role "user" (fresh start model)
 			const summaryMessage = result.messages.find((msg) => msg.isSummary)
@@ -164,7 +170,13 @@ Line 2
 				{ role: "user", content: "Fifth message" },
 			]
 
-			const result = await summarizeConversation(messages, mockApiHandler, "System prompt", taskId, false)
+			const result = await summarizeConversation({
+				messages,
+				apiHandler: mockApiHandler,
+				systemPrompt: "System prompt",
+				taskId,
+				isAutomaticTrigger: false,
+			})
 
 			// All original messages should be tagged with condenseParent
 			const taggedMessages = result.messages.filter((msg) => !msg.isSummary)
@@ -193,7 +205,13 @@ Line 2
 				{ role: "user", content: "Ninth message" },
 			]
 
-			const result = await summarizeConversation(messages, mockApiHandler, "System prompt", taskId, false)
+			const result = await summarizeConversation({
+				messages,
+				apiHandler: mockApiHandler,
+				systemPrompt: "System prompt",
+				taskId,
+				isAutomaticTrigger: false,
+			})
 
 			const summaryMessage = result.messages.find((msg) => msg.isSummary)
 			expect(summaryMessage).toBeTruthy()
@@ -227,7 +245,13 @@ Line 2
 				{ role: "user", content: "Perfect!" },
 			]
 
-			const result = await summarizeConversation(messages, mockApiHandler, "System prompt", taskId, false)
+			const result = await summarizeConversation({
+				messages,
+				apiHandler: mockApiHandler,
+				systemPrompt: "System prompt",
+				taskId,
+				isAutomaticTrigger: false,
+			})
 
 			// Effective history should contain only the summary (fresh start)
 			const effectiveHistory = getEffectiveApiHistory(result.messages)
@@ -239,7 +263,13 @@ Line 2
 		it("should return error when not enough messages to summarize", async () => {
 			const messages: ApiMessage[] = [{ role: "user", content: "Only one message" }]
 
-			const result = await summarizeConversation(messages, mockApiHandler, "System prompt", taskId, false)
+			const result = await summarizeConversation({
+				messages,
+				apiHandler: mockApiHandler,
+				systemPrompt: "System prompt",
+				taskId,
+				isAutomaticTrigger: false,
+			})
 
 			// Should return an error since we have only 1 message
 			expect(result.error).toBeDefined()
@@ -253,7 +283,13 @@ Line 2
 				{ role: "user", content: "Previous summary", isSummary: true },
 			]
 
-			const result = await summarizeConversation(messages, mockApiHandler, "System prompt", taskId, false)
+			const result = await summarizeConversation({
+				messages,
+				apiHandler: mockApiHandler,
+				systemPrompt: "System prompt",
+				taskId,
+				isAutomaticTrigger: false,
+			})
 
 			// Should return an error due to recent summary with no substantial messages after
 			expect(result.error).toBeDefined()
@@ -286,7 +322,13 @@ Line 2
 				{ role: "user", content: "Seventh" },
 			]
 
-			const result = await summarizeConversation(messages, emptyHandler, "System prompt", taskId, false)
+			const result = await summarizeConversation({
+				messages,
+				apiHandler: emptyHandler,
+				systemPrompt: "System prompt",
+				taskId,
+				isAutomaticTrigger: false,
+			})
 
 			expect(result.error).toBeDefined()
 			expect(result.messages).toEqual(messages)

src/core/condense/__tests__/foldedFileContext.spec.ts

@@ -298,19 +298,15 @@ describe("foldedFileContext", () => {
 			const filesReadByRoo = ["src/user.ts", "src/api.ts"]
 			const cwd = "/test/project"
 
-			const result = await summarizeConversation(
+			const result = await summarizeConversation({
 				messages,
-				mockApiHandler,
-				"System prompt",
+				apiHandler: mockApiHandler,
+				systemPrompt: "System prompt",
 				taskId,
-				false,
-				undefined, // customCondensingPrompt
-				undefined, // metadata
-				undefined, // environmentDetails
+				isAutomaticTrigger: false,
 				filesReadByRoo,
 				cwd,
-				undefined, // rooIgnoreController
-			)
+			})
 
 			// Verify generateFoldedFileContext was called with the right arguments
 			expect(mockedGenerateFoldedFileContext).toHaveBeenCalledWith(filesReadByRoo, {
@@ -367,19 +363,15 @@ describe("foldedFileContext", () => {
 			// Reset the mock to ensure clean state
 			mockedGenerateFoldedFileContext.mockClear()
 
-			const result = await summarizeConversation(
+			const result = await summarizeConversation({
 				messages,
-				mockApiHandler,
-				"System prompt",
+				apiHandler: mockApiHandler,
+				systemPrompt: "System prompt",
 				taskId,
-				false,
-				undefined, // customCondensingPrompt
-				undefined, // metadata
-				undefined, // environmentDetails
-				[], // Empty filesReadByRoo array
-				"/test/project",
-				undefined, // rooIgnoreController
-			)
+				isAutomaticTrigger: false,
+				filesReadByRoo: [],
+				cwd: "/test/project",
+			})
 
 			// generateFoldedFileContext should NOT be called when filesReadByRoo is empty
 			expect(mockedGenerateFoldedFileContext).not.toHaveBeenCalled()