Skip to content
This repository was archived by the owner on May 15, 2026. It is now read-only.

Commit d5cb177

Browse files
committed
remove publish marketplace
1 parent 6879ca3 commit d5cb177

3 files changed

Lines changed: 94 additions & 16 deletions

File tree

.github/workflows/marketplace-publish.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,6 @@ jobs:
5757
git tag -a "v${current_package_version}" -m "Release v${current_package_version}"
5858
git push origin "v${current_package_version}" --no-verify
5959
echo "Successfully created and pushed git tag v${current_package_version}"
60-
- name: Publish Extension
61-
env:
62-
VSCE_PAT: ${{ secrets.VSCE_PAT }}
63-
OVSX_PAT: ${{ secrets.OVSX_PAT }}
64-
run: |
65-
current_package_version=$(node -p "require('./src/package.json').version")
66-
pnpm --filter roo-cline publish:marketplace
67-
echo "Successfully published version $current_package_version to VS Code Marketplace"
6860
- name: Create GitHub Release
6961
env:
7062
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/nightly-publish.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,3 @@ jobs:
4242
EOF
4343
- name: Build VSIX
4444
run: pnpm vsix:nightly # Produces bin/roo-code-nightly-0.0.[count].vsix
45-
- name: Publish to VS Code Marketplace
46-
env:
47-
VSCE_PAT: ${{ secrets.VSCE_PAT }}
48-
run: npx vsce publish --packagePath "bin/$(/bin/ls bin | head -n1)"
49-
- name: Publish to Open VSX Registry
50-
env:
51-
OVSX_PAT: ${{ secrets.OVSX_PAT }}
52-
run: npx ovsx publish "bin/$(ls bin | head -n1)"
Lines changed: 94 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
# Remove VSIX publish steps design
2+
3+
Date: 2026-05-10
4+
5+
## Problem
6+
Two GitHub workflows still do local packaging *and* publish to registries:
7+
- `.github/workflows/marketplace-publish.yml`
8+
- `.github/workflows/nightly-publish.yml`
9+
10+
User wants to keep:
11+
- `.vsix` build
12+
- git tag creation
13+
- GitHub Release creation
14+
15+
User wants to remove only registry publish steps:
16+
- VS Code Marketplace publish
17+
- Open VSX publish
18+
19+
## Goals
20+
- Keep VSIX packaging in both workflows.
21+
- Keep git tag creation in `marketplace-publish.yml`.
22+
- Keep GitHub Release creation in `marketplace-publish.yml`.
23+
- Remove all registry publish steps from both workflows.
24+
25+
## Non-goals
26+
- No changes to `.vsix` packaging commands.
27+
- No changes to git tag logic.
28+
- No changes to GitHub Release logic.
29+
- No changes to workflow triggers or job permissions unless needed by removed steps.
30+
- No changes to app code or package scripts.
31+
32+
## Design
33+
### 1) Remove Marketplace publish from release workflow
34+
In `.github/workflows/marketplace-publish.yml`, delete the `Publish Extension` step that runs:
35+
- `pnpm --filter roo-cline publish:marketplace`
36+
37+
Keep:
38+
- `Package Extension`
39+
- `Create and Push Git Tag`
40+
- `Create GitHub Release`
41+
42+
### 2) Remove registry publish from nightly workflow
43+
In `.github/workflows/nightly-publish.yml`, delete both publishing steps:
44+
- `Publish to VS Code Marketplace`
45+
- `Publish to Open VSX Registry`
46+
47+
Keep:
48+
- checkout
49+
- node/pnpm setup
50+
- nightly version patching
51+
- `Build VSIX`
52+
53+
### 3) Preserve build artifacts
54+
Both workflows should still leave the packaged `.vsix` in `bin/` so it can be used by:
55+
- GitHub Release assets in the release workflow
56+
- local inspection or later upload steps if added later
57+
58+
## Data flow after change
59+
### marketplace-publish.yml
60+
1. Trigger on release-related PR close or manual dispatch.
61+
2. Checkout code.
62+
3. Setup Node/pnpm.
63+
4. Package extension into `.vsix`.
64+
5. Create/push git tag.
65+
6. Create GitHub Release with `.vsix` attached.
66+
7. No registry publish happens.
67+
68+
### nightly-publish.yml
69+
1. Trigger on `main` push or manual dispatch.
70+
2. Checkout code.
71+
3. Setup Node/pnpm.
72+
4. Patch nightly version.
73+
5. Build `.vsix`.
74+
6. No registry publish happens.
75+
76+
## Risks
77+
- Nightly workflow no longer publishes to registries automatically.
78+
- Release workflow no longer publishes to Marketplace automatically.
79+
- Release distribution now depends on GitHub Release only.
80+
81+
These risks are accepted by request.
82+
83+
## Testing
84+
- Verify `marketplace-publish.yml` no longer contains `publish:marketplace`.
85+
- Verify `nightly-publish.yml` no longer contains Marketplace/Open VSX publish commands.
86+
- Verify both workflows still contain packaging/build steps.
87+
- Verify `marketplace-publish.yml` still contains git tag and GitHub Release steps.
88+
89+
## Acceptance criteria
90+
- `marketplace-publish.yml` no longer publishes to VS Code Marketplace.
91+
- `nightly-publish.yml` no longer publishes to VS Code Marketplace or Open VSX.
92+
- Both workflows still build `.vsix`.
93+
- `marketplace-publish.yml` still tags and creates GitHub Release.
94+
- No app code or package script changes required.

0 commit comments

Comments
 (0)