Skip to content
This repository was archived by the owner on May 15, 2026. It is now read-only.

Commit e55d690

Browse files
SannidhyaSannidhya
authored andcommitted
fix: address PR review feedback
- Add skills list refresh after deleteSkill to prevent race condition - Fix frontend validation regex to match backend spec (no consecutive/trailing hyphens)
1 parent 1be4424 commit e55d690

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

src/core/webview/webviewMessageHandler.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3062,7 +3062,9 @@ export const webviewMessageHandler = async (
30623062

30633063
await skillsManager.deleteSkill(skillName, source, skillMode)
30643064

3065-
// UI will handle refresh via setTimeout
3065+
// Send updated skills list
3066+
const skills = skillsManager.getSkillsMetadata()
3067+
await provider.postMessageToWebview({ type: "skills", skills })
30663068
} catch (error) {
30673069
const errorMessage = error instanceof Error ? error.message : String(error)
30683070
provider.log(`Error deleting skill: ${errorMessage}`)

webview-ui/src/components/settings/CreateSkillDialog.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,16 @@ interface CreateSkillDialogProps {
2727

2828
/**
2929
* Validate skill name according to agentskills.io spec:
30-
* - Must start with a letter
3130
* - Only lowercase letters, numbers, and hyphens allowed
31+
* - No leading/trailing hyphens
32+
* - No consecutive hyphens
3233
* - 1-64 characters
3334
*/
3435
const validateSkillName = (name: string): string | null => {
3536
if (!name) return "settings:skills.validation.nameRequired"
3637
if (name.length > 64) return "settings:skills.validation.nameTooLong"
37-
if (!/^[a-z][a-z0-9-]*$/.test(name)) {
38+
// Match backend validation: /^[a-z0-9]+(?:-[a-z0-9]+)*$/
39+
if (!/^[a-z0-9]+(?:-[a-z0-9]+)*$/.test(name)) {
3840
return "settings:skills.validation.nameInvalid"
3941
}
4042
return null

0 commit comments

Comments
 (0)