fix: resolve type errors and remove AI SDK test contamination

Author: hannesrudolph

src/api/providers/__tests__/gemini.spec.ts

@@ -1,7 +1,5 @@
 // npx vitest run src/api/providers/__tests__/gemini.spec.ts
 
-import { NoOutputGeneratedError } from "ai"
-
 const mockCaptureException = vitest.fn()
 
 vitest.mock("@roo-code/telemetry", () => ({
@@ -105,84 +103,6 @@ describe("GeminiHandler", () => {
 			)
 		})
 
-		it("should yield informative message when stream produces no text content", async () => {
-			// Stream with only reasoning (no text-delta) simulates thinking-only response
-			const mockFullStream = (async function* () {
-				yield { type: "reasoning-delta", id: "1", text: "thinking..." }
-			})()
-
-			mockStreamText.mockReturnValue({
-				fullStream: mockFullStream,
-				usage: Promise.resolve({ inputTokens: 10, outputTokens: 0 }),
-				providerMetadata: Promise.resolve({}),
-			})
-
-			const stream = handler.createMessage(systemPrompt, mockMessages)
-			const chunks = []
-
-			for await (const chunk of stream) {
-				chunks.push(chunk)
-			}
-
-			// Should have: reasoning chunk, empty-stream informative message, usage
-			const textChunks = chunks.filter((c) => c.type === "text")
-			expect(textChunks).toHaveLength(1)
-			expect(textChunks[0]).toEqual({
-				type: "text",
-				text: "Model returned an empty response. This may be caused by an unsupported thinking configuration or content filtering.",
-			})
-		})
-
-		it("should suppress NoOutputGeneratedError when no text content was yielded", async () => {
-			// Empty stream - nothing yielded at all
-			const mockFullStream = (async function* () {
-				// empty stream
-			})()
-
-			mockStreamText.mockReturnValue({
-				fullStream: mockFullStream,
-				usage: Promise.reject(new NoOutputGeneratedError({ message: "No output generated." })),
-				providerMetadata: Promise.resolve({}),
-			})
-
-			const stream = handler.createMessage(systemPrompt, mockMessages)
-			const chunks = []
-
-			// Should NOT throw - the error is suppressed
-			for await (const chunk of stream) {
-				chunks.push(chunk)
-			}
-
-			// Should have the informative empty-stream message only (no usage since it errored)
-			const textChunks = chunks.filter((c) => c.type === "text")
-			expect(textChunks).toHaveLength(1)
-			expect(textChunks[0]).toMatchObject({
-				type: "text",
-				text: expect.stringContaining("empty response"),
-			})
-		})
-
-		it("should re-throw NoOutputGeneratedError when text content was yielded", async () => {
-			// Stream yields text content but usage still throws NoOutputGeneratedError (unexpected)
-			const mockFullStream = (async function* () {
-				yield { type: "text-delta", text: "Hello" }
-			})()
-
-			mockStreamText.mockReturnValue({
-				fullStream: mockFullStream,
-				usage: Promise.reject(new NoOutputGeneratedError({ message: "No output generated." })),
-				providerMetadata: Promise.resolve({}),
-			})
-
-			const stream = handler.createMessage(systemPrompt, mockMessages)
-
-			await expect(async () => {
-				for await (const _chunk of stream) {
-					// consume stream
-				}
-			}).rejects.toThrow()
-		})
-
 		it("should handle API errors", async () => {
 			const mockError = new Error("Gemini API error")
 			;(handler["client"].models.generateContentStream as any).mockRejectedValue(mockError)

src/api/providers/vertex.ts

@@ -16,7 +16,13 @@ export class VertexHandler extends GeminiHandler implements SingleCompletionHand
 		const modelId = this.options.apiModelId
 		let id = modelId && modelId in vertexModels ? (modelId as VertexModelId) : vertexDefaultModelId
 		const info: ModelInfo = vertexModels[id]
-		const params = getModelParams({ format: "gemini", modelId: id, model: info, settings: this.options })
+		const params = getModelParams({
+			format: "gemini",
+			modelId: id,
+			model: info,
+			settings: this.options,
+			defaultTemperature: info.defaultTemperature ?? 1,
+		})
 
 		// The `:thinking` suffix indicates that the model is a "Hybrid"
 		// reasoning model and that reasoning is required to be enabled.

src/api/providers/xai.ts

@@ -43,7 +43,13 @@ export class XAIHandler extends BaseProvider implements SingleCompletionHandler
 				: xaiDefaultModelId
 
 		const info = xaiModels[id]
-		const params = getModelParams({ format: "openai", modelId: id, model: info, settings: this.options })
+		const params = getModelParams({
+			format: "openai",
+			modelId: id,
+			model: info,
+			settings: this.options,
+			defaultTemperature: XAI_DEFAULT_TEMPERATURE,
+		})
 		return { id, info, ...params }
 	}