refactor: move generateFoldedFileContext() inside summarizeConversation()

- Update summarizeConversation() to accept filesReadByRoo, cwd, rooIgnoreController instead of pre-generated sections
- Move folded file context generation inside summarizeConversation() (lines 319-339)
- Update ContextManagementOptions type and manageContext() to pass new parameters
- Remove generateFoldedFileContext from Task.ts imports - folding now handled internally
- Update all tests to use new parameter signature
- Reduces Task.ts complexity by moving folding logic to summarization module

Author: hannesrudolph

src/core/condense/__tests__/foldedFileContext.spec.ts

@@ -11,9 +11,20 @@ vi.mock("../../../services/tree-sitter", () => ({
 	parseSourceCodeDefinitionsForFile: vi.fn(),
 }))
 
+// Mock generateFoldedFileContext for summarizeConversation tests
+vi.mock("../foldedFileContext", async (importOriginal) => {
+	const actual = await importOriginal<typeof import("../foldedFileContext")>()
+	return {
+		...actual,
+		generateFoldedFileContext: vi.fn().mockImplementation(actual.generateFoldedFileContext),
+	}
+})
+
 import { generateFoldedFileContext } from "../foldedFileContext"
 import { parseSourceCodeDefinitionsForFile } from "../../../services/tree-sitter"
 
+const mockedGenerateFoldedFileContext = vi.mocked(generateFoldedFileContext)
+
 const mockedParseSourceCodeDefinitions = vi.mocked(parseSourceCodeDefinitionsForFile)
 
 describe("foldedFileContext", () => {
@@ -262,8 +273,8 @@ describe("foldedFileContext", () => {
 				{ role: "user", content: "Seventh message" },
 			]
 
-			// Folded file context sections - each file in its own <system-reminder> block
-			const foldedFileContextSections = [
+			// Mock generateFoldedFileContext to return the expected folded sections
+			const mockFoldedSections = [
 				`<system-reminder>
 ## File Context: src/user.ts
 1--5 | export interface User
@@ -276,6 +287,17 @@ describe("foldedFileContext", () => {
 </system-reminder>`,
 			]
 
+			mockedGenerateFoldedFileContext.mockResolvedValue({
+				content: mockFoldedSections.join("\n"),
+				sections: mockFoldedSections,
+				filesProcessed: 2,
+				filesSkipped: 0,
+				characterCount: mockFoldedSections.join("\n").length,
+			})
+
+			const filesReadByRoo = ["src/user.ts", "src/api.ts"]
+			const cwd = "/test/project"
+
 			const result = await summarizeConversation(
 				messages,
 				mockApiHandler,
@@ -285,9 +307,17 @@ describe("foldedFileContext", () => {
 				undefined, // customCondensingPrompt
 				undefined, // metadata
 				undefined, // environmentDetails
-				foldedFileContextSections, // Array of sections, each file in its own block
+				filesReadByRoo,
+				cwd,
+				undefined, // rooIgnoreController
 			)
 
+			// Verify generateFoldedFileContext was called with the right arguments
+			expect(mockedGenerateFoldedFileContext).toHaveBeenCalledWith(filesReadByRoo, {
+				cwd,
+				rooIgnoreController: undefined,
+			})
+
 			// Verify the summary was created
 			expect(result.summary).toBeDefined()
 			expect(result.messages.length).toBeGreaterThan(0)
@@ -318,7 +348,7 @@ describe("foldedFileContext", () => {
 			expect(apiFileBlock.text).toContain("fetchData")
 		})
 
-		it("should not include file context section when foldedFileContextSections is empty", async () => {
+		it("should not include file context section when filesReadByRoo is empty", async () => {
 			const { summarizeConversation } = await import("../index")
 
 			const mockApiHandler = new MockApiHandler()
@@ -334,6 +364,9 @@ describe("foldedFileContext", () => {
 				{ role: "user", content: "Seventh message" },
 			]
 
+			// Reset the mock to ensure clean state
+			mockedGenerateFoldedFileContext.mockClear()
+
 			const result = await summarizeConversation(
 				messages,
 				mockApiHandler,
@@ -343,9 +376,14 @@ describe("foldedFileContext", () => {
 				undefined, // customCondensingPrompt
 				undefined, // metadata
 				undefined, // environmentDetails
-				[], // Empty foldedFileContextSections array
+				[], // Empty filesReadByRoo array
+				"/test/project",
+				undefined, // rooIgnoreController
 			)
 
+			// generateFoldedFileContext should NOT be called when filesReadByRoo is empty
+			expect(mockedGenerateFoldedFileContext).not.toHaveBeenCalled()
+
 			// Find the summary message
 			const summaryMessage = result.messages.find((msg: any) => msg.isSummary)
 			expect(summaryMessage).toBeDefined()

src/core/condense/index.ts

@@ -9,9 +9,11 @@ import { ApiMessage } from "../task-persistence/apiMessages"
 import { maybeRemoveImageBlocks } from "../../api/transform/image-cleaning"
 import { findLast } from "../../shared/array"
 import { supportPrompt } from "../../shared/support-prompt"
+import { RooIgnoreController } from "../ignore/RooIgnoreController"
 
 // Re-export folded file context utilities
-export { generateFoldedFileContext } from "./foldedFileContext"
+import { generateFoldedFileContext } from "./foldedFileContext"
+export { generateFoldedFileContext }
 export type { FoldedFileContextResult, FoldedFileContextOptions } from "./foldedFileContext"
 
 export const MIN_CONDENSE_THRESHOLD = 5 // Minimum percentage of context window to trigger condensing
@@ -153,7 +155,9 @@ export type SummarizeResponse = {
  * @param {string} customCondensingPrompt - Optional custom prompt to use for condensing
  * @param {ApiHandlerCreateMessageMetadata} metadata - Optional metadata to pass to createMessage (tools, taskId, etc.)
  * @param {string} environmentDetails - Optional environment details string to include in the summary (only used when isAutomaticTrigger=true)
- * @param {string[]} foldedFileContextSections - Optional array of folded file context sections (each file in its own <system-reminder> block)
+ * @param {string[]} filesReadByRoo - Optional array of file paths read by Roo during the task (will be folded via tree-sitter)
+ * @param {string} cwd - Optional current working directory for resolving file paths (required if filesReadByRoo is provided)
+ * @param {RooIgnoreController} rooIgnoreController - Optional controller for file access validation
  * @returns {SummarizeResponse} - The result of the summarization operation (see above)
  */
 export async function summarizeConversation(
@@ -165,7 +169,9 @@ export async function summarizeConversation(
 	customCondensingPrompt?: string,
 	metadata?: ApiHandlerCreateMessageMetadata,
 	environmentDetails?: string,
-	foldedFileContextSections?: string[],
+	filesReadByRoo?: string[],
+	cwd?: string,
+	rooIgnoreController?: RooIgnoreController,
 ): Promise<SummarizeResponse> {
 	TelemetryService.instance.captureContextCondensed(
 		taskId,
@@ -308,16 +314,27 @@ ${commandBlocks}
 		})
 	}
 
-	// Add folded file context (smart code folding) if present
+	// Generate and add folded file context (smart code folding) if file paths are provided
 	// Each file gets its own <system-reminder> block as a separate content block
-	if (foldedFileContextSections && foldedFileContextSections.length > 0) {
-		for (const section of foldedFileContextSections) {
-			if (section.trim()) {
-				summaryContent.push({
-					type: "text",
-					text: section,
-				})
+	if (filesReadByRoo && filesReadByRoo.length > 0 && cwd) {
+		try {
+			const foldedResult = await generateFoldedFileContext(filesReadByRoo, {
+				cwd,
+				rooIgnoreController,
+			})
+			if (foldedResult.sections.length > 0) {
+				for (const section of foldedResult.sections) {
+					if (section.trim()) {
+						summaryContent.push({
+							type: "text",
+							text: section,
+						})
+					}
+				}
 			}
+		} catch (error) {
+			console.error("[summarizeConversation] Failed to generate folded file context:", error)
+			// Continue without folded context - non-critical failure
 		}
 	}