This repository was archived by the owner on May 15, 2026. It is now read-only.
feat: improve context budget truncation notice with total lines and continuation example - #10249
Closed
ghost wants to merge 2 commits into
Closed
feat: improve context budget truncation notice with total lines and continuation example#10249ghost wants to merge 2 commits into
ghost wants to merge 2 commits into
Conversation
…ontinuation example When files are truncated due to context budget limits, the truncation notice now includes: - Total number of lines in the file - The next line number to continue from - A concrete example of the line_range syntax This helps models understand why they received fewer lines than expected and how to continue reading. Addresses Issue #10239
Author
Reviewed the latest commit addressing @pwilkin's feedback. No issues found. The new commit correctly updates both truncation notices with concrete line_range syntax examples:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
Contributor
|
@roomote You missed the fragment in ReadFileTool: that truncates due to end of definition. |
Author
Fixed the reported issues. All local checks passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #10239 (specifically the comment about semantic truncation notifications).
Problem
When files are truncated due to context budget limits, the current truncation notice says:
This notice does not include:
This can cause models to be confused about why they received fewer lines than expected, leading to re-read attempts.
Solution
Improved the truncation notice to include all relevant information:
Before:
After:
Changes
src/core/tools/ReadFileTool.ts- Updated the context budget truncation notice to include:Testing
Feedback and guidance are welcome!