This repository was archived by the owner on May 15, 2026. It is now read-only.
fix: queued messages with only images now properly sent to UI and LLM - #11026
Closed
ghost wants to merge 1 commit into
Closed
fix: queued messages with only images now properly sent to UI and LLM#11026ghost wants to merge 1 commit into
ghost wants to merge 1 commit into
Conversation
Fixes EXT-639 where queued messages containing only images (no text)
would vanish after being dequeued without being shown in the UI or
sent to the LLM.
Root cause: processQueuedMessages called submitUserMessage which
sets askResponse values, but those values are only consumed when
there is a pending ask(). When called after tool execution (no
pending ask), the content was lost.
Fix: Changed processQueuedMessages to directly:
1. Show user feedback in UI via say("user_feedback", ...)
2. Add content to userMessageContent array for the next LLM request
3. Handle image-only messages with hasText || hasImages check
Added test to verify image-only queued messages work correctly.
Author
Review completed. No issues found. The fix correctly addresses the root cause where queued messages containing only images would vanish because Changes verified:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: Linear issue EXT-639
Roo Code Task Context (Optional)
N/A
Description
Fixes a bug where queued messages containing only images (no text) would vanish after being dequeued without being shown in the UI or sent to the LLM.
Root cause:
processQueuedMessagescalledsubmitUserMessagewhich setsaskResponsevalues, but those values are only consumed when there is a pendingask(). When called after tool execution (no pending ask), the content was lost - this was especially problematic for image-only messages.Fix: Changed
processQueuedMessagesto directly:say("user_feedback", ...)userMessageContentarray for the next LLM requesthasText || hasImagescheck (previously the logic only worked when text was present)Test Procedure
cd src && npx vitest run core/task/__tests__/Task.spec.tsPre-Submission Checklist
Screenshots / Videos
N/A - backend logic change, no UI changes
Documentation Updates
Additional Notes
Key changes in
Task.ts:processQueuedMessages()now directly adds queued message content touserMessageContentarrayformatResponse.imageBlocks()to convert image data URLs to proper Anthropic ImageBlockParam format<user_message>tags consistent with other user feedback handlingGet in Touch
N/A - this is an automated fix from Roo Code Cloud
Important
Fixes
processQueuedMessages()inTask.tsto correctly handle image-only messages and updates tests to verify this behavior.processQueuedMessages()inTask.tsto handle image-only messages by checkinghasText || hasImages.userMessageContentusingformatResponse.imageBlocks().Task.spec.tsto verify handling of image-only messages.This description was created by
for ef66ce6. You can customize this summary. It will automatically update as commits are pushed.