Skip to content
This repository was archived by the owner on May 15, 2026. It is now read-only.

fix(openai): only include parallel_tool_calls when explicitly enabled #11074

Draft
ghost wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(openai): only include parallel_tool_calls when explicitly enabled #11074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/api/providers/__tests__/openai.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,6 @@ describe("OpenAiHandler", () => {
temperature: 0,
tools: undefined,
tool_choice: undefined,
parallel_tool_calls: true,
},
{ path: "/models/chat/completions" },
)
Expand Down Expand Up @@ -684,7 +683,6 @@ describe("OpenAiHandler", () => {
],
tools: undefined,
tool_choice: undefined,
parallel_tool_calls: true,
},
{ path: "/models/chat/completions" },
)
Expand Down
2 changes: 1 addition & 1 deletion src/api/providers/base-openai-compatible-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export abstract class BaseOpenAiCompatibleProvider<ModelName extends string>
stream_options: { include_usage: true },
tools: this.convertToolsForOpenAI(metadata?.tools),
tool_choice: metadata?.tool_choice,
parallel_tool_calls: metadata?.parallelToolCalls ?? true,
...(metadata?.parallelToolCalls === true && { parallel_tool_calls: true }),
}

// Add thinking parameter if reasoning is enabled and model supports it
Expand Down
8 changes: 4 additions & 4 deletions src/api/providers/openai.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ export class OpenAiHandler extends BaseProvider implements SingleCompletionHandl
...(reasoning && reasoning),
tools: this.convertToolsForOpenAI(metadata?.tools),
tool_choice: metadata?.tool_choice,
parallel_tool_calls: metadata?.parallelToolCalls ?? true,
...(metadata?.parallelToolCalls === true && { parallel_tool_calls: true }),
}

// Add max_tokens if needed
Expand Down Expand Up @@ -229,7 +229,7 @@ export class OpenAiHandler extends BaseProvider implements SingleCompletionHandl
// Tools are always present (minimum ALWAYS_AVAILABLE_TOOLS)
tools: this.convertToolsForOpenAI(metadata?.tools),
tool_choice: metadata?.tool_choice,
parallel_tool_calls: metadata?.parallelToolCalls ?? true,
...(metadata?.parallelToolCalls === true && { parallel_tool_calls: true }),
}

// Add max_tokens if needed
Expand Down Expand Up @@ -348,7 +348,7 @@ export class OpenAiHandler extends BaseProvider implements SingleCompletionHandl
// Tools are always present (minimum ALWAYS_AVAILABLE_TOOLS)
tools: this.convertToolsForOpenAI(metadata?.tools),
tool_choice: metadata?.tool_choice,
parallel_tool_calls: metadata?.parallelToolCalls ?? true,
...(metadata?.parallelToolCalls === true && { parallel_tool_calls: true }),
}

// O3 family models do not support the deprecated max_tokens parameter
Expand Down Expand Up @@ -382,7 +382,7 @@ export class OpenAiHandler extends BaseProvider implements SingleCompletionHandl
// Tools are always present (minimum ALWAYS_AVAILABLE_TOOLS)
tools: this.convertToolsForOpenAI(metadata?.tools),
tool_choice: metadata?.tool_choice,
parallel_tool_calls: metadata?.parallelToolCalls ?? true,
...(metadata?.parallelToolCalls === true && { parallel_tool_calls: true }),
}

// O3 family models do not support the deprecated max_tokens parameter
Expand Down
Loading