This repository was archived by the owner on May 15, 2026. It is now read-only.
feat: add GPT-5.4 Codex Spark fast models - #12113
Draft
ghost wants to merge 1 commit into
Draft
Conversation
Add gpt-5.4-codex-spark and gpt-5.4-mini-codex-spark model variants to the OpenAI Codex provider, following the existing gpt-5.3-codex-spark pattern. These are fast, text-only coding models with 128k context and 8192 max output tokens, accessible via ChatGPT subscription. Closes #12112
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #12112
Description
This PR attempts to address Issue #12112 by adding GPT-5.4 fast/spark model variants to the OpenAI Codex provider. Feedback and guidance are welcome.
Following the existing
gpt-5.3-codex-sparkpattern, this adds two new models:gpt-5.4-codex-spark- Fast, text-only coding model based on GPT-5.4gpt-5.4-mini-codex-spark- Fast, text-only coding model based on GPT-5.4 MiniThese spark variants have the same characteristics as the existing 5.3 spark model:
Test Procedure
openai-codex.spec.tsverifying model IDs resolve correctlycd src && npx vitest run api/providers/__tests__/openai-codex.spec.tsPre-Submission Checklist
Documentation Updates
Additional Notes
The spark model specs (context window, max tokens, capabilities) are based on the existing
gpt-5.3-codex-sparkpattern. If OpenAI publishes different specs for GPT-5.4 spark variants, the values may need adjustment.Interactively review PR in Roo Code Cloud