This repository was archived by the owner on May 15, 2026. It is now read-only.
fix: improve lock icon visibility in API config popover - #12239
Draft
ghost wants to merge 1 commit into
Draft
Conversation
- Replace subtle IconButton with a visible Button + text label ("Locked"/"Unlocked")
- Use text-vscode-descriptionForeground instead of opacity-60 for unlocked state
- Add StandardTooltip explaining the lock function on hover
- Ensure cursor:pointer is always present
- Add i18n keys for "locked"/"unlocked" labels in all 18 locales
- Update tests to match new styling classes
ghost
force-pushed
the
fix/lock-icon-visibility-12237
branch
from
April 30, 2026 13:30
556d703 to
650f52a
Compare
ghost
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #12237
Description
This PR attempts to address the lock icon visibility issues reported in Issue #12237. The user reported that the lock/unlock icon in the API Configuration popover is effectively invisible and provides no hover feedback.
Changes:
IconButton(which usedopacity-60for the unlocked state) with a more visibleButtonthat includes a text label ("Locked" / "Unlocked") next to the icontext-vscode-descriptionForegroundwithopacity-90instead ofopacity-60for the unlocked state, making it visible on all themestext-vscode-focusBorderfor the locked state (highlighted)StandardTooltipexplaining the lock function on hovercursor: pointeris always present via explicit classFeedback and guidance are welcome.
Test Procedure
cd webview-ui && npx vitest run src/components/chat/__tests__/ApiConfigSelector.spec.tsx-- all 21 tests passcd webview-ui && npx vitest run src/components/chat/__tests__/ChatTextArea.lockApiConfig.spec.tsx-- all 5 tests passPre-Submission Checklist