Refactor pimpl pointers in XMLSchemaComplexTypeGenerator and XMLValidator to unique_ptr#661
Open
lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
Open
Conversation
…ator to unique_ptr Replace raw owning `class Impl*` members with `std::unique_ptr<class Impl>`, allowing destructors to be defaulted and making ownership explicit in the type system.
lyskov
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
class Impl*pimpl members withstd::unique_ptr<class Impl>inXMLSchemaComplexTypeGeneratorandXMLValidator{ delete pimpl_; }to= default, letting the compiler generate correct cleanup#include <memory>to both headersMotivation
Both classes already correctly suppressed copy/move with
= delete, so there was no double-free risk. This refactor makes ownership explicit in the type system and eliminates manualdeletecalls, following the Rule of Zero pattern for pimpl idiom.Testing
Full debug build succeeds. No behavior change — pure ownership semantics refactor.