Modernize copy prevention in utility/signals classes to use = delete#668
Open
lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
Open
Modernize copy prevention in utility/signals classes to use = delete#668lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
Conversation
Replace old-style private-and-undefined copy constructor/assignment declarations with explicit = delete in SignalHub, BufferedSignalHub, PausableSignalHub, TokenHub, and LinkUnit. Also deletes the LinkUnit default constructor the same way.
lyskov
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
utility/signalsclasses with explicit= deleteSignalHub,BufferedSignalHub,PausableSignalHub,TokenHub,LinkUnitLinkUnitdefault constructor (was previously also private-undefined)Motivation
The pre-C++11 idiom of declaring copy ops private with no definition produces a linker error on misuse rather than a clear compile-time diagnostic.
= deletegives an immediate, descriptive compiler error at the call site and is the modern idiomatic approach.Test plan
python3 ./scons.py -j16 mode=debugpasses (headers-only change; no behavioral difference)