Skip to content

Modernize copy prevention in factory/Registrant to use = delete #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lyskov-ai wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −13
Open

Modernize copy prevention in factory/Registrant to use = delete #670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions source/src/utility/factory/Registrant.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,6 @@ public: // Types
typedef typename ProductFactory::Create Create; // Product creation function


private: // Creation


/// @brief Copy constructor
Registrant( Registrant const & ); // Undefined


public: // Creation


Expand Down Expand Up @@ -175,12 +168,9 @@ public: // Creation
}


private: // Assignment


/// @brief Copy assignment
Registrant &
operator =( Registrant const & ); // Undefined
// Each constructor calls ProductFactory::add(); a copy would silently re-register the same key.
Registrant( Registrant const & ) = delete;
Registrant & operator =( Registrant const & ) = delete;


}; // Registrant
Expand Down