Modernize copy prevention in basic_otstream and TracerImpl#674
Open
lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
Open
Modernize copy prevention in basic_otstream and TracerImpl#674lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
Conversation
basic_otstream: replace private undefined copy ctor with explicit = delete in the public section for both copy ctor and copy assignment. Add a comment explaining why: the destructor calls delete this->rdbuf(), so a copy sharing the same buffer would cause a double-free. TracerImpl: move the already-deleted copy ctor from private to public and add the missing copy assignment = delete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
basic_otstream: replace private-undefined copy ctor with explicit= deletefor both copy ctor and copy assignment in the public section. Adds a one-liner comment explaining the destructor side-effect (delete this->rdbuf()causes double-free if two objects share the same buffer).TracerImpl: move the already-= deleted copy ctor from private section to public, and add the missing copy assignment= delete.Part of the ongoing Rule-of-Zero / modern C++ idiom cleanup in
basic/.🤖 Generated with Claude Code