Modernize copy prevention in Emitter, YamlEmitter, and JsonEmitter#678
Open
lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
Open
Modernize copy prevention in Emitter, YamlEmitter, and JsonEmitter#678lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
Conversation
Replace private/protected undefined copy ctor declarations with explicit = delete in the public section, and add the missing copy assignment = delete. Also remove the redundant undefined null-ctor declarations (suppressed automatically in C++11 by the presence of user-declared non-default ctors).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Emitter,YamlEmitter,JsonEmitter: replace private/protected undefined copy ctor declarations with explicit= deletein the public section, and add the missing copy assignment= delete.YamlEmitterandJsonEmitter— these were suppressed automatically in C++11 by the presence of user-declared non-default constructors.Part of the ongoing Rule-of-Zero / modern C++ idiom cleanup in
basic/.🤖 Generated with Claude Code