Skip to content

Fix key map range indexing#680

Open
lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
lyskov-ai:fix/key-map-range-indexing
Open

Fix key map range indexing#680
lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
lyskov-ai:fix/key-map-range-indexing

Conversation

@lyskov-ai
Copy link
Copy Markdown
Contributor

Summary

  • fix ClassKeyMap and SmallKeyMap range constructor/assignment loops to visit the final 1-indexed element
  • add regression coverage for range construction and assignment preserving the final key

Testing

  • python3 ./scons.py -j16 mode=debug cat=test
  • python3 test/run.py -j16 --mode=debug KeyMapTests SmallKeyMapTests
  • python3 ./scons.py -j16 mode=release bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant