Default MetricValue special members#684
Open
lyskov-ai wants to merge 2 commits intoRosettaCommons:mainfrom
Open
Default MetricValue special members#684lyskov-ai wants to merge 2 commits intoRosettaCommons:mainfrom
lyskov-ai wants to merge 2 commits intoRosettaCommons:mainfrom
Conversation
lyskov
approved these changes
May 1, 2026
CI build (gcc with -Werror=unused-parameter) flagged the named parameter on the defaulted copy constructor as unused. Drop the name; the defaulted body still copies the source.
lyskov-ai
force-pushed
the
refactor/metric-value-default-members
branch
from
32851eb to
e91f32a
Compare
roccomoretti
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing